From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace non-clickable checkbox with icons
Date: Tue, 24 Jan 2023 16:30:03 +0100 [thread overview]
Message-ID: <225a50b5-2326-7205-1eab-a9cbd0b16fdd@proxmox.com> (raw)
In-Reply-To: <5d124158-1ce3-81b9-e1cd-60f4bc20b894@proxmox.com>
Am 24/01/2023 um 16:24 schrieb Thomas Lamprecht:
>> - dataIndex: 'Enabled',
>> - listeners: {
>> - beforecheckchange: () => false, // veto, we don't want to allow inline change - to subtle
>> + dataindex: 'Enabled',
>> + align: 'center',
>> + renderer: function(enabled, cell, record) {
>> + return Proxmox.Utils.render_enabled_icon(record.data.Enabled);
>> },
> could be a one liner without losing clarity:
>
> renderer: ({data}) => Proxmox.Utils.renderEnabledIcon(data.Enabled),
>
Actually, as in my reply to 2/2, you break setting dataIndex by writing it
all lowercase, as otherwise you should be able to configure the renderer
function directly, without intermediate call
next prev parent reply other threads:[~2023-01-24 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 13:17 [pve-devel] [PATCH v2 manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes " Lukas Wagner
2023-01-23 13:17 ` [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace non-clickable checkbox " Lukas Wagner
2023-01-24 15:24 ` Thomas Lamprecht
2023-01-24 15:30 ` Thomas Lamprecht [this message]
2023-01-23 13:17 ` [pve-devel] [PATCH v2 manager] ui: backup: replication: " Lukas Wagner
2023-01-24 15:28 ` Thomas Lamprecht
2023-01-24 15:37 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=225a50b5-2326-7205-1eab-a9cbd0b16fdd@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox