From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [RFC PATCH installer] proxinstall, common: remove deprecated fletcher2 as zfs checksum algorithm
Date: Tue, 6 Feb 2024 13:17:57 +0100 [thread overview]
Message-ID: <222f82a1-64f2-4706-a7d2-08095e2866e2@proxmox.com> (raw)
In-Reply-To: <20231222105244.715015-1-c.heiss@proxmox.com>
Am 22/12/2023 um 11:52 schrieb Christoph Heiss:
> Fletcher-2 has long been deprecated and should not be used anymore
> [0][1], so we probably should not offer it anymore too. It's been
> deprecated since at least over 3 years, beyond that it's hard to find an
> exact date.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
>
> [0] https://openzfs.github.io/openzfs-docs/Basic%20Concepts/Checksums.html#checksum-algorithms
> [1] https://people.freebsd.org/~asomers/fletcher.pdf
please keep the git-trailes, like your S-o-b, always at the bottom.
References like these above are part of the commit message, not the
Developer Certificate of Origin S-o-b or patch meta stuff like R-b
or T-b trailers.
> ---
> Sending this as RFC since it might warrant some discussions.
>
> While digging into this a bit more, I reckon we should remove 'off' as
> an option too. It's considered an "extraordinarily bad idea" [2] (for to
> pretty obvious reason) and nobody should ever use it.
>
> Might be a good idea, just so that users simply disable checksum "for
> performance reasons" without knowing about the implications of this.
yeah, would make sense, especially as anybody can still disable those
afterwards using the `zfs` CLI tool, for whatever reason that may be.
The alternative would be either showing a hint if `off` is selected,
or change the combobox entry label of it to something like:
`off (NOT recommended)`
But just to mention all options, I'm fine with this being dropped,
if lots of users complain with somewhat reasonable justification then
we could always re-add it with aforementioned hint.
> [2] https://openzfs.github.io/openzfs-docs/Basic%20Concepts/Checksums.html#disabling-checksums
>
> proxinstall | 2 +-
> proxmox-installer-common/src/options.rs | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2024-02-06 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 10:52 [pve-devel] " Christoph Heiss
2024-02-06 12:17 ` Thomas Lamprecht [this message]
2024-02-06 13:03 ` [pve-devel] applied: " Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=222f82a1-64f2-4706-a7d2-08095e2866e2@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox