From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lorenz Stechauner <l.stechauner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v4 storage 1/1] fix #3580: plugins: make preallocation mode selectable for qcow2 and raw images
Date: Thu, 14 Oct 2021 11:23:15 +0200 [thread overview]
Message-ID: <222d2260-78d3-93c9-7b55-9803bb737d3e@proxmox.com> (raw)
In-Reply-To: <20211012123234.31818-2-l.stechauner@proxmox.com>
On 12.10.21 14:32, Lorenz Stechauner wrote:
> the plugins for file based storages
> * BTRFS
> * CIFS
> * Dir
> * Glusterfs
> * NFS
> now allow the option 'preallocation'.
>
> 'preallocation' can have four values:
> * default
> * off
> * metadata
> * falloc
> * full
> see man pages for `qemu-img` for what these mean exactly. [0]
>
> the defualt value was chosen to be
> * qcow2: metadata (as previously)
> * raw: off
>
> when using 'metadata' as preallocation mode, for raw images 'off'
> is used.
>
> [0] https://qemu.readthedocs.io/en/latest/system/images.html#disk-image-file-formats
>
> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
> Tested-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/Storage/BTRFSPlugin.pm | 1 +
> PVE/Storage/CIFSPlugin.pm | 1 +
> PVE/Storage/DirPlugin.pm | 1 +
> PVE/Storage/GlusterfsPlugin.pm | 4 ++-
> PVE/Storage/NFSPlugin.pm | 1 +
> PVE/Storage/Plugin.pm | 48 +++++++++++++++++++++++++++++++++-
> 6 files changed, 54 insertions(+), 2 deletions(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2021-10-14 9:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 12:32 [pve-devel] [PATCH-SERIES v4 storage/manager] fix #3580: " Lorenz Stechauner
2021-10-12 12:32 ` [pve-devel] [PATCH v4 storage 1/1] fix #3580: plugins: " Lorenz Stechauner
2021-10-14 9:23 ` Thomas Lamprecht [this message]
2021-10-12 12:32 ` [pve-devel] [PATCH v4 manager 1/2] ui: add PreallocationSelector Lorenz Stechauner
2021-10-21 10:18 ` [pve-devel] applied: " Thomas Lamprecht
2021-10-12 12:32 ` [pve-devel] [PATCH v4 manager 2/2] fix 3850: ui: storage: using PreallocationSelector for file based storage types Lorenz Stechauner
2021-10-21 10:18 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=222d2260-78d3-93c9-7b55-9803bb737d3e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox