From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [RFC ifupdown2] d/maintscripts: use postinst arguments to determine first install
Date: Thu, 14 Nov 2024 18:40:22 +0100 [thread overview]
Message-ID: <21fb2bd7-73ff-45da-b8ab-0f9c30b9f17c@proxmox.com> (raw)
In-Reply-To: <20241113190359.686689-1-s.ivanov@proxmox.com>
Am 13.11.24 um 20:03 schrieb Stoiko Ivanov:
> Following https://www.debian.org/doc/debian-policy/ap-flowcharts.html
> postinst gets called as 'postinst configure' w/o second argument on
> first installation, use that information instead of creating a
> flag-file in preinst.
>
> Technically this changes the semantics and the first-install parts
> will not be run, in case ifupdown2 had been installed on the system,
> but was subsequently removed, but not purged ('rc' in dpkg-output).
> Since the functionality was added quite a while ago (released with PVE
> 6.2 to support ovs-setups with ifupdown2 - the potential for
> regression should be limited. Originally introduced in:
> 849ae55de6454ea4631de0899182c148c954e46a
FWIW, I got a git-alias named show-short that resolves to
show --no-patch --pretty='format: %C(auto)%h ("%s")'
which I use for such references. The main benefit is having the subject
of a commit, which gives some more context without having to check the
history, or allows quickly searching on other sources (e.g., lore for
kernel or our stuff) if the commit would reference another repo.
I do not have all to hard feelings here and am *very* happy about any
Fixes tag, whatever form it is, compared to none at all, just mentioning
it, maybe you see some similar benefits in a similar format.
>
> Fixes: 8d5303c35044b612afc68eec1dc5bc265a5dd328
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> sending as RFC, as I'm not sure that the small cosmetic fix is worth
> the potetial regressions at all, but after spending a bit too long
> reading the commit-history and the debian-policy manual thought I'll
> send it anyways.
> (Tested with mmebstrap and in an install on top of debian)
>
> debian/ifupdown2.postinst | 3 +--
> debian/ifupdown2.preinst | 20 --------------------
> 2 files changed, 1 insertion(+), 22 deletions(-)
> delete mode 100644 debian/ifupdown2.preinst
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-14 17:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 19:03 [pve-devel] " Stoiko Ivanov
2024-11-14 17:40 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21fb2bd7-73ff-45da-b8ab-0f9c30b9f17c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox