From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH container] fix #4765: lxc: report cpu usage correctly
Date: Sat, 24 Jun 2023 17:39:59 +0200 [thread overview]
Message-ID: <21e0a654-3d93-88f2-3a57-395b7a2e31be@proxmox.com> (raw)
In-Reply-To: <4ab17011-52ca-9bf5-05e6-7a5b8dadb6b3@proxmox.com>
Am 23/06/2023 um 13:54 schrieb Fiona Ebner:
> IMHO, the average of the CPU usage across the whole uptime is not what
> most people would expect this value to be.
Yeah, this is really not that useful in most cases.
> Maybe we should just remove the line from the output like in qm (technically
> a breaking change)
Luckily we have a more pragmatic approach to breaking changes that isn't
strictly bound by technicalities.
So yes, as it was hardcoded 0 and thus completely useless I'd also just drop
it. You can 100% redirect all fault to me if somebody complaints.
prev parent reply other threads:[~2023-06-24 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 15:46 Maximiliano Sandoval
2023-06-23 11:54 ` Fiona Ebner
2023-06-24 15:39 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21e0a654-3d93-88f2-3a57-395b7a2e31be@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox