From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shan Shaji <s.shaji@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend 2/3] feat: ui: add bottom sheet to change VMs/CTs options
Date: Tue, 23 Sep 2025 14:03:59 +0200 [thread overview]
Message-ID: <21924f8b-a3e6-48ee-acbd-2d4a8787b907@proxmox.com> (raw)
In-Reply-To: <20250923093629.119418-3-s.shaji@proxmox.com>
Am 23.09.25 um 11:37 schrieb Shan Shaji:
> On the options page for VMs and CTs it was easy to change the configs by
> mistake. To avoid add a bottom sheet to show the editable option.
>
> The value will only be updated when the `update` button is pressed.
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
> .../pve_config_switch_form.dart | 54 ++++++
> lib/widgets/pve_config_list_tile.dart | 176 +++++++++++++++++
> lib/widgets/pve_lxc_options_widget.dart | 78 +++++---
> lib/widgets/pve_qemu_options_widget.dart | 177 ++++++++++++------
> 4 files changed, 400 insertions(+), 85 deletions(-)
> create mode 100644 lib/widgets/pve_config_forms/pve_config_switch_form.dart
> create mode 100644 lib/widgets/pve_config_list_tile.dart
>
> diff --git a/lib/widgets/pve_config_forms/pve_config_switch_form.dart b/lib/widgets/pve_config_forms/pve_config_switch_form.dart
> new file mode 100644
> index 0000000..61ae014
> --- /dev/null
> +++ b/lib/widgets/pve_config_forms/pve_config_switch_form.dart
> @@ -0,0 +1,54 @@
> +import 'package:flutter/material.dart';
> +import 'package:pve_flutter_frontend/widgets/pve_config_tile.dart';
Above does not exist, should probably be the newly added "pve_config_list_tile.dart" file?
I.e.:
diff --git a/lib/widgets/pve_config_forms/pve_config_switch_form.dart b/lib/widgets/pve_config_forms/pve_config_switch_form.dart
index 61ae014..40bef8c 100644
--- a/lib/widgets/pve_config_forms/pve_config_switch_form.dart
+++ b/lib/widgets/pve_config_forms/pve_config_switch_form.dart
@@ -1,5 +1,5 @@
import 'package:flutter/material.dart';
-import 'package:pve_flutter_frontend/widgets/pve_config_tile.dart';
+import 'package:pve_flutter_frontend/widgets/pve_config_list_tile.dart';
class PveConfigSwitchForm extends StatefulWidget {
const PveConfigSwitchForm({
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-09-23 12:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 9:36 [pve-devel] [PATCH pve_flutter_frontend 0/3] feat: ui: add bottom sheet to show editable options of VMs/CTs Shan Shaji
2025-09-23 9:36 ` [pve-devel] [PATCH pve_flutter_frontend 1/3] cleanup: run `dart format` on both qemu and lxc options page Shan Shaji
2025-09-23 9:36 ` [pve-devel] [PATCH pve_flutter_frontend 2/3] feat: ui: add bottom sheet to change VMs/CTs options Shan Shaji
2025-09-23 12:03 ` Thomas Lamprecht [this message]
2025-09-23 12:12 ` Shan Shaji
2025-09-23 12:24 ` Shan Shaji
2025-09-23 9:36 ` [pve-devel] [PATCH pve_flutter_frontend 3/3] cleanup: remove `PveConfigSwitchListTile` in favor of PveConfigListTile Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21924f8b-a3e6-48ee-acbd-2d4a8787b907@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox