From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager v3 1/3] fix #3903: jobs: add remove vmid from jobs helper
Date: Mon, 14 Mar 2022 11:18:49 +0100 [thread overview]
Message-ID: <2166d56d-2ddc-bce2-029a-40c8f59e0d12@proxmox.com> (raw)
In-Reply-To: <151939ee-75b2-1b4f-d420-16f0641e8f22@proxmox.com>
Am 14.03.22 um 11:00 schrieb Fabian Ebner:
> Am 14.03.22 um 10:26 schrieb Hannes Laimer:
>> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
>> @@ -274,6 +274,25 @@ sub synchronize_job_states_with_config {
>> die $@ if $@;
>> }
>>
>> +sub remove_vmid_from_jobs {
>> + my ($vmid) = @_;
>> +
>> + cfs_lock_file('jobs.cfg', undef, sub {
>> + my $jobs_data = cfs_read_file('jobs.cfg');
>> + for my $id (keys %{$jobs_data->{ids}}) {
>> + my $job = $jobs_data->{ids}->{$id};
>> + my $type = $job->{type};
>> + my $plugin = PVE::Jobs::Plugin->lookup($type);
>> + $jobs_data->{ids}->{$id} = $plugin->remove_vmid_from_job($job, $vmid);
>> + if (!defined($jobs_data->{ids}->{$id})) {
>> + delete $jobs_data->{ids}->{$id};
>
> If it's not defined, delete shouldn't be necessary anymore.
Well, assuming the writer handles that correctly. Actually, I don't mind
having the delete here after all.
next prev parent reply other threads:[~2022-03-14 10:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 9:26 [pve-devel] [PATCH-SERIES v3] fix #3903: remove vmid from jobs.cfg on destroy Hannes Laimer
2022-03-14 9:26 ` [pve-devel] [PATCH pve-manager v3 1/3] fix #3903: jobs: add remove vmid from jobs helper Hannes Laimer
2022-03-14 10:00 ` Fabian Ebner
2022-03-14 10:18 ` Fabian Ebner [this message]
2022-03-15 10:52 ` [pve-devel] [PATCH pve-manager v4 " Hannes Laimer
2022-03-14 9:26 ` [pve-devel] [PATCH pve-container v3 2/3] fix #3903: api2: remove vmid from jobs.cfg Hannes Laimer
2022-03-14 9:26 ` [pve-devel] [PATCH qemu-server v3 3/3] " Hannes Laimer
2022-03-16 7:15 ` [pve-devel] [PATCH-SERIES v3] fix #3903: remove vmid from jobs.cfg on destroy Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2166d56d-2ddc-bce2-029a-40c8f59e0d12@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox