[pve-devel] [PATCH manager] ContentView: block removal of in-use container image

[pve-devel] [PATCH manager] ContentView: block removal of in-use container image

[Fabian Ebner]

Since commit 5dae1a319b32ea3ebbb0b48a9f0b5e3abd1833c9 in pve-storage,
list_volumes correctly returns content type 'rootdir' for container images.
Adapt the relevant check here to make removal behave like it does
for VM images again.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 www/manager6/storage/ContentView.js | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js
index c70c732c..194ad42e 100644
--- a/www/manager6/storage/ContentView.js
+++ b/www/manager6/storage/ContentView.js
@@ -432,7 +432,8 @@ Ext.define('PVE.storage.ContentView', {
 	    selModel: sm,
 	    delay: 5,
 	    enableFn: function(rec) {
-		if (rec && rec.data.content !== 'images') {
+		if (rec && rec.data.content !== 'images' &&
+			   rec.data.content !== 'rootdir') {
 		    imageRemoveButton.setVisible(false);
 		    removeButton.setVisible(true);
 		    return true;
@@ -450,7 +451,8 @@ Ext.define('PVE.storage.ContentView', {
 	    hidden: true,
 	    text: gettext('Remove'),
 	    enableFn: function(rec) {
-		if (rec && rec.data.content === 'images') {
+		if (rec && (rec.data.content === 'images' ||
+			    rec.data.content === 'rootdir')) {
 		    removeButton.setVisible(false);
 		    imageRemoveButton.setVisible(true);
 		    return true;
-- 
2.20.1

[pve-devel] applied: Re: [PATCH manager] ContentView: block removal of in-use container image

[Thomas Lamprecht]

On 8/27/20 1:16 PM, Fabian Ebner wrote:
> Since commit 5dae1a319b32ea3ebbb0b48a9f0b5e3abd1833c9 in pve-storage,
> list_volumes correctly returns content type 'rootdir' for container images.
> Adapt the relevant check here to make removal behave like it does
> for VM images again.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  www/manager6/storage/ContentView.js | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
>

applied, thanks!

[pve-devel] sdn patches ready for review

[Alexandre DERUMIER]

Hi everybody,

I think my summer work on sdn is ready for review.
I have implemented subnet/nat/ipam/dns registration.

I'll stop to add new feature for now, I have planned time in september for fixes,cleanup.

Here the different patch series:


[pve-devel] [PATCH v7 pve-network 00/21] sdn : add subnets management
https://lists.proxmox.com/pipermail/pve-devel/2020-August/044850.html

[pve-devel] [PATCH v4 pve-manager 0/8] sdn : add subnets management
https://lists.proxmox.com/pipermail/pve-devel/2020-August/044775.html


[pve-devel] [PATCH v4 pve-cluster 0/4] sdn : add subnets management
https://lists.proxmox.com/pipermail/pve-devel/2020-August/044770.html

[pve-devel] [PATCH v2 pve-docs 0/2] simple zone + subnet/ipam documentation
https://lists.proxmox.com/pipermail/pve-devel/2020-August/044874.html




For testing subnet/ipam in lxc (is really a poc, do not apply) ->

[pve-devel] [PATCH v2 pve-container] POC : add/del/update ip from vnet-subnet-ipam
https://lists.proxmox.com/pipermail/pve-devel/2020-August/044781.html

Currently, if you use a vnet with subnet with registered ipam, and you keep the ip field empty, it'll auto-assign an ip.
(or you can still defined your own ip, it'll be registered in pam too)

Re: [pve-devel] sdn patches ready for review

[Thomas Lamprecht]

Hi,

On 8/28/20 2:51 PM, Alexandre DERUMIER wrote:
> Hi everybody,
> 
> I think my summer work on sdn is ready for review.
> I have implemented subnet/nat/ipam/dns registration.

cool!

> 
> I'll stop to add new feature for now, I have planned time in september for fixes,cleanup.

Ok, thanks for the information! I'll allocate a few hours next week to give
initial feedback.
I already skimmed each iteration of your patches shallowly, nothing made any
alarm bells ring, so from what I can tell now, it should head in the right
directions.

The features are definitively nice and I think many PVE users would like to have
them quite a bit.

> Here the different patch series:
> 
> 
> [pve-devel] [PATCH v7 pve-network 00/21] sdn : add subnets management
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044850.html
> 
> [pve-devel] [PATCH v4 pve-manager 0/8] sdn : add subnets management
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044775.html
> 
> 
> [pve-devel] [PATCH v4 pve-cluster 0/4] sdn : add subnets management
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044770.html
> 
> [pve-devel] [PATCH v2 pve-docs 0/2] simple zone + subnet/ipam documentation
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044874.html
> 
> 
> For testing subnet/ipam in lxc (is really a poc, do not apply) ->
> 
> [pve-devel] [PATCH v2 pve-container] POC : add/del/update ip from vnet-subnet-ipam
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044781.html
> 
> Currently, if you use a vnet with subnet with registered ipam, and you keep the ip field empty, it'll auto-assign an ip.
> (or you can still defined your own ip, it'll be registered in pam too)
> 
> 

OK. Do you already use this new stuff somewhere in your setups?

Re: [pve-devel] sdn patches ready for review

[Alexandre DERUMIER]

>>OK. Do you already use this new stuff somewhere in your setups? 

Not yet. (we are going to migrate all our cluster to bgp-evpn in coming months, but I'm waiting the subnet management, as I have move the gateway ip definition in subnet)
 

Currently at work, we manage ipam (netbox) /dns (powerdns) for vm creation with some custom scripts + puppet plugged to ipam to generate guestos config.

But when I'll be ready, I'm going to use them with proxmox directly.
It still need work to add ip management on lxc but also qemu.
(I don't use yet cloud-init in production, but I'm currently playing with it,I'm able to reload online config with some udev tricks,...)






----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht@proxmox.com>
À: "aderumier" <aderumier@odiso.com>
Cc: "pve-devel" <pve-devel@pve.proxmox.com>
Envoyé: Vendredi 28 Août 2020 15:09:29
Objet: Re: sdn patches ready for review

Hi, 

On 8/28/20 2:51 PM, Alexandre DERUMIER wrote: 
> Hi everybody, 
> 
> I think my summer work on sdn is ready for review. 
> I have implemented subnet/nat/ipam/dns registration. 

cool! 

> 
> I'll stop to add new feature for now, I have planned time in september for fixes,cleanup. 

Ok, thanks for the information! I'll allocate a few hours next week to give 
initial feedback. 
I already skimmed each iteration of your patches shallowly, nothing made any 
alarm bells ring, so from what I can tell now, it should head in the right 
directions. 

The features are definitively nice and I think many PVE users would like to have 
them quite a bit. 

> Here the different patch series: 
> 
> 
> [pve-devel] [PATCH v7 pve-network 00/21] sdn : add subnets management 
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044850.html 
> 
> [pve-devel] [PATCH v4 pve-manager 0/8] sdn : add subnets management 
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044775.html 
> 
> 
> [pve-devel] [PATCH v4 pve-cluster 0/4] sdn : add subnets management 
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044770.html 
> 
> [pve-devel] [PATCH v2 pve-docs 0/2] simple zone + subnet/ipam documentation 
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044874.html 
> 
> 
> For testing subnet/ipam in lxc (is really a poc, do not apply) -> 
> 
> [pve-devel] [PATCH v2 pve-container] POC : add/del/update ip from vnet-subnet-ipam 
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044781.html 
> 
> Currently, if you use a vnet with subnet with registered ipam, and you keep the ip field empty, it'll auto-assign an ip. 
> (or you can still defined your own ip, it'll be registered in pam too) 
> 
> 

OK. Do you already use this new stuff somewhere in your setups? 

Re: [pve-devel] sdn patches ready for review

[Alexandre Aderumier]

Hi, I have send new patch series for pve-network (v10), pve-manager (v6).
They need pve-cluster v5 that I have sent last week.

I have also send a new poc for pve-container.

I have retested all the features subnets/dns/ipams with differents plugins,
all seem to working fine.
(I'm going to write to test units soon, because it's really take time to do
it manually ;)

So, now ipam/dns options are setup on zone, you can define same subnets on
different zones,  pending config are displayed (I'm displaying change in
the grid with a new renderer, so maybe it'll need to little bit of polish).

I think the gui is easy to use now.

I'll rework pve-docs after theses series are applied.

Alexandre

Le ven. 28 août 2020 à 14:53, Alexandre DERUMIER <aderumier@odiso.com> a
écrit :

> Hi everybody,
>
> I think my summer work on sdn is ready for review.
> I have implemented subnet/nat/ipam/dns registration.
>
> I'll stop to add new feature for now, I have planned time in september for
> fixes,cleanup.
>
> Here the different patch series:
>
>
> [pve-devel] [PATCH v7 pve-network 00/21] sdn : add subnets management
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044850.html
>
> [pve-devel] [PATCH v4 pve-manager 0/8] sdn : add subnets management
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044775.html
>
>
> [pve-devel] [PATCH v4 pve-cluster 0/4] sdn : add subnets management
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044770.html
>
> [pve-devel] [PATCH v2 pve-docs 0/2] simple zone + subnet/ipam documentation
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044874.html
>
>
>
>
> For testing subnet/ipam in lxc (is really a poc, do not apply) ->
>
> [pve-devel] [PATCH v2 pve-container] POC : add/del/update ip from
> vnet-subnet-ipam
> https://lists.proxmox.com/pipermail/pve-devel/2020-August/044781.html
>
> Currently, if you use a vnet with subnet with registered ipam, and you
> keep the ip field empty, it'll auto-assign an ip.
> (or you can still defined your own ip, it'll be registered in pam too)
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>