From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH storage] storage migration: insecure: improve logging
Date: Thu, 11 Feb 2021 10:46:42 +0100 [thread overview]
Message-ID: <213467e1-fb76-5d5f-064b-45ce9a61b5b7@proxmox.com> (raw)
In-Reply-To: <20210211094200.20664-1-f.ebner@proxmox.com>
This breaks pvesr replication, because the -T switch is active there.
I'll send a v2 and preserve the regex captures.
Am 11.02.21 um 10:42 schrieb Fabian Ebner:
> by including the message/error from the remote side. Some people on the forum [0]
> ran into 'no tunnel IP received', but without information from the remote side
> it's hard to tell why.
>
> [0]: https://forum.proxmox.com/threads/failed-no-tunnel-ip-received.80172
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/Storage.pm | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/Storage.pm b/PVE/Storage.pm
> index 22a6ef1..3c03abe 100755
> --- a/PVE/Storage.pm
> +++ b/PVE/Storage.pm
> @@ -758,8 +758,16 @@ sub storage_migrate {
> or die "receive command failed: $!\n";
> close($input);
>
> - my ($ip) = <$info> =~ /^($PVE::Tools::IPRE)$/ or die "no tunnel IP received\n";
> - my ($port) = <$info> =~ /^(\d+)$/ or die "no tunnel port received\n";
> + my $ip = <$info> // '';
> + chomp($ip);
> + die "no tunnel IP received, got '$ip'\n"
> + if $ip !~ /^$PVE::Tools::IPRE$/;
> +
> + my $port = <$info> // '';
> + chomp($port);
> + die "no tunnel port received, got '$port'\n"
> + if $port !~ /^\d+$/;
> +
> my $socket = IO::Socket::IP->new(PeerHost => $ip, PeerPort => $port, Type => SOCK_STREAM)
> or die "failed to connect to tunnel at $ip:$port\n";
> # we won't be reading from the socket
>
prev parent reply other threads:[~2021-02-11 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 9:42 Fabian Ebner
2021-02-11 9:46 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=213467e1-fb76-5d5f-064b-45ce9a61b5b7@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox