From: Dietmar Maurer <dietmar@proxmox.com>
To: PVE Development List <pve-devel@pve.proxmox.com>
Subject: [pve-devel] vncpropxy question
Date: Thu, 30 Jun 2022 13:02:03 +0200 (CEST) [thread overview]
Message-ID: <212652737.3945.1656586923044@webmail.proxmox.com> (raw)
in qemu-server, I wonder why we set $ENV{LC_PVE_TICKET} conditionally? Does not make any sense to me, because it make all other connection failing...
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 99b426e..c6a3ac1 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -2102,7 +2102,7 @@ __PACKAGE__->register_method({
} else {
- $ENV{LC_PVE_TICKET} = $password if $websocket; # set ticket with "qm vncproxy"
+ $ENV{LC_PVE_TICKET} = $password;
$cmd = [@$remcmd, "/usr/sbin/qm", 'vncproxy', $vmid];
next reply other threads:[~2022-06-30 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 11:02 Dietmar Maurer [this message]
2022-06-30 11:25 ` Dominik Csapak
2022-06-30 11:50 ` Dominik Csapak
2022-06-30 11:55 ` Thomas Lamprecht
2022-07-01 6:39 Dietmar Maurer
2022-07-01 12:01 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=212652737.3945.1656586923044@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pve-devel@pve.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox