public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Mira Limbeck <m.limbeck@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Daniel Herzig <d.herzig@proxmox.com>
Subject: Re: [pve-devel] [PATCH 2/8 container] cloudinit: basic implementation
Date: Thu, 13 Feb 2025 13:02:43 +0100	[thread overview]
Message-ID: <20c54275-0148-4eea-b83f-63b7741ad4db@proxmox.com> (raw)
In-Reply-To: <080f00b4-2530-4369-9e9a-3d7e44c1cbed@proxmox.com>

Am 13.02.25 um 12:29 schrieb Mira Limbeck:
> On 2/13/25 12:01, Fiona Ebner wrote:
>> Am 10.02.25 um 13:07 schrieb Daniel Herzig:
>>> +sub gen_cloudinit_metadata {
>>> +    my ($user) = @_;
>>> +
>>> +    my $uuid_str = Digest::SHA::sha1_hex($user);
>>
>> Hmm, shouldn't this also depend on the vendor data? Otherwise, if only
>> the vendor data changes, then it will still have the same instance ID.
>>
>> Seems like for VMs, we only use user and network data here.
>>
>> @Mira do you know more by chance?
> I don't think vendor-data should be part of the instance-id. It's used
> to create a first configuration that a user can override via the user
> config.
> The vendor-data won't be used again once it's already configured.
> I'm not a 100% sure, but changing the instance-id leads to rerunning
> lots of modules (e.g. User, Network and others), but the vendor-data
> parts do not.
> 
> Only a complete `cloud-init clean` should trigger the modules using
> vendor-data to run again.
> 
> 
> https://cloudinit.readthedocs.io/en/latest/explanation/vendordata.html#vendor-data

Oh, thank you for the explanation!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-02-13 12:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 12:07 [pve-devel] [PATCH 0/8 container/manager/docs] fix #4686: Cloudinit support for LXC Daniel Herzig
2025-02-10 12:07 ` [pve-devel] [PATCH 1/8 container] cloudinit: introduce config parameters Daniel Herzig
2025-02-13 10:10   ` Fiona Ebner
2025-02-13 10:18     ` Mira Limbeck
2025-02-13 10:22       ` Fiona Ebner
2025-02-13 10:23   ` Fiona Ebner
2025-02-13 15:05     ` Daniel Herzig
2025-02-13 12:15   ` Fiona Ebner
2025-02-10 12:07 ` [pve-devel] [PATCH 2/8 container] cloudinit: basic implementation Daniel Herzig
2025-02-13 11:01   ` Fiona Ebner
2025-02-13 11:29     ` Mira Limbeck
2025-02-13 12:02       ` Fiona Ebner [this message]
2025-02-13 15:09       ` Daniel Herzig
2025-02-13 12:06     ` Fiona Ebner
2025-02-10 12:07 ` [pve-devel] [PATCH 3/8 container] cloudinit: add dump command to pct Daniel Herzig
2025-02-13 12:00   ` Fiona Ebner
2025-02-10 12:07 ` [pve-devel] [PATCH 4/8 container] cloudinit: add function dumping options for docs Daniel Herzig
2025-02-10 12:07 ` [pve-devel] [PATCH 5/8 manager] cloudinit: rename qemu cloudinit panel Daniel Herzig
2025-02-10 12:07 ` [pve-devel] [PATCH 6/8 manager] cloudinit: introduce panel for LXCs Daniel Herzig
2025-02-10 12:07 ` [pve-devel] [PATCH 7/8 docs] pct: add script to generate cloudinit options Daniel Herzig
2025-02-13  9:52   ` Fiona Ebner
2025-02-10 12:07 ` [pve-devel] [PATCH 8/8 docs] pct: document cloudinit for LXC Daniel Herzig
2025-02-12 15:46   ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20c54275-0148-4eea-b83f-63b7741ad4db@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.herzig@proxmox.com \
    --cc=m.limbeck@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal