public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH storage] btrfs: free image: only remove snapshots for current subvol
Date: Wed, 6 Oct 2021 13:41:16 +0200	[thread overview]
Message-ID: <2066330c-4a62-1315-14e9-65094765b919@proxmox.com> (raw)
In-Reply-To: <20210913090142.35311-1-f.ebner@proxmox.com>

Ping, because more people ran into this (see forum thread).

Am 13.09.21 um 11:01 schrieb Fabian Ebner:
> instead of all in the same directory.
> 
> Reported in the community forum:
> https://forum.proxmox.com/threads/error-could-not-statfs-no-such-file-or-directory.96057/
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>   PVE/Storage/BTRFSPlugin.pm | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/Storage/BTRFSPlugin.pm b/PVE/Storage/BTRFSPlugin.pm
> index dbc1244..0ebb43b 100644
> --- a/PVE/Storage/BTRFSPlugin.pm
> +++ b/PVE/Storage/BTRFSPlugin.pm
> @@ -6,7 +6,7 @@ use warnings;
>   use base qw(PVE::Storage::Plugin);
>   
>   use Fcntl qw(S_ISDIR O_WRONLY O_CREAT O_EXCL);
> -use File::Basename qw(dirname);
> +use File::Basename qw(basename dirname);
>   use File::Path qw(mkpath);
>   use IO::Dir;
>   use POSIX qw(EEXIST);
> @@ -421,9 +421,11 @@ sub free_image {
>       }
>   
>       my $dir = dirname($subvol);
> +    my $basename = basename($subvol);
>       my @snapshot_vols;
>       foreach_subvol($dir, sub {
>   	my ($volume, $name, $snapshot) = @_;
> +	return if $name ne $basename;
>   	return if !defined $snapshot;
>   	push @snapshot_vols, "$dir/$volume";
>       });
> 




  reply	other threads:[~2021-10-06 11:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13  9:01 Fabian Ebner
2021-10-06 11:41 ` Fabian Ebner [this message]
2021-10-06 11:54 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2066330c-4a62-1315-14e9-65094765b919@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal