public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH v3 manager 18/18] pvestatd: notify on NVMe over Fabrics namespaces as on multipath maps
Date: Sun, 22 Nov 2026 02:25:55 +0100	[thread overview]
Message-ID: <20261122012605.1848824-19-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20261122012605.1848824-1-t.lamprecht@proxmox.com>

The report of a node lists the namespaces of its NVMe over Fabrics
storages next to the multipath maps, so the notifications about lost
and restored paths cover them too. Name the storages of a namespace in
them as for a map, also the one that has it as base volume.

A report whose namespaces could not be listed counts as incomplete, so
that they are not taken as gone. A node that cannot query multipathd
sends no notifications, also not for its namespaces, which its report
still lists.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 PVE/MultipathNotification.pm       | 5 +++--
 PVE/Service/pvestatd.pm            | 2 +-
 test/MultipathNotification_test.pl | 3 +++
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/PVE/MultipathNotification.pm b/PVE/MultipathNotification.pm
index 99c79405b..d25851d0c 100644
--- a/PVE/MultipathNotification.pm
+++ b/PVE/MultipathNotification.pm
@@ -97,8 +97,9 @@ sub flush($self, $notify) {
 sub update($self, $report, $notify) {
     my $usable = ref($report) eq 'HASH' && !$report->{error} && !$report->{'scope-unknown'};
     my $luns = $usable ? $report->{luns} : undef;
-    # without the hints of LVM, maps known only by their volume group can be left out
-    my $complete = $usable && !$report->{'vgs-unknown'};
+    # without the hints of LVM, maps known only by their volume group can be left out, and a failed
+    # query leaves out the NVMe namespaces
+    my $complete = $usable && !$report->{'vgs-unknown'} && !$report->{'namespaces-unknown'};
     my $previous = $self->{previous};
     my $current = $self->{previous} = {};
     if (!defined($luns)) {
diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
index 68d7f2e08..5cdce325a 100755
--- a/PVE/Service/pvestatd.pm
+++ b/PVE/Service/pvestatd.pm
@@ -814,7 +814,7 @@ my sub notify_multipath {
         my $scfg = PVE::Storage::storage_check_node($storage, $sid, $nodename, 1) // next;
         push $by_vg{ $scfg->{vgname} }->@*, $sid if defined($scfg->{vgname});
         my $base = PVE::Multipath::parse_base_volume($scfg->{base});
-        push $by_wwid{ $base->{wwid} }->@*, $sid if $base && $base->{kind} ne 'nvme';
+        push $by_wwid{ $base->{wwid} }->@*, $sid if $base;
     }
 
     my $data = PVE::Notify::common_template_data();
diff --git a/test/MultipathNotification_test.pl b/test/MultipathNotification_test.pl
index f78a31e6e..d61ce6ea1 100755
--- a/test/MultipathNotification_test.pl
+++ b/test/MultipathNotification_test.pl
@@ -93,6 +93,9 @@ pass_with(
 $tracker = PVE::MultipathNotification->new($file);
 pass_with({}, [], 'notified LUNs left the report across a restart');
 pass_with({}, [], 'but an incomplete report does not count', 0);
+report_with(
+    { luns => [], 'namespaces-unknown' => 1 }, [], 'nor one without the NVMe namespaces',
+);
 pass_with(
     {},
     [['info', 'c:gone', 'd:gone']],




      parent reply	other threads:[~2026-11-22  1:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-22  1:25 [PATCH v3 storage,docs,manager 00/18] NVMe over Fabrics storage Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 storage 01/18] diskmanage: skip SMART queries for NVMe fabric namespaces Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 storage 02/18] nvmeof: add a storage for NVMe over Fabrics subsystems Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 storage 03/18] lvm: allow a volume group on an NVMe over Fabrics namespace Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 storage 04/18] api: scan: add NVMe over Fabrics discovery Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 storage 05/18] pvesm: add a scan command for NVMe over Fabrics Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 storage 06/18] api: san luns: attribute NVMe namespaces to storage Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 storage 07/18] api: add node-level NVMe over Fabrics status and controller removal Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 storage 08/18] multipath: report the NVMe host NQN of each node Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 storage 09/18] multipath: report NVMe over Fabrics namespaces in the cluster status Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 docs 10/18] storage: document NVMe over Fabrics storages Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 manager 11/18] report: add the NVMe over Fabrics host NQN and subsystems Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 manager 12/18] ui: storage: add NVMe over Fabrics storage Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 manager 13/18] ui: lvm: offer NVMe over Fabrics storages as base storage Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 manager 14/18] ui: storage: add a guided setup for shared LVM on NVMe over Fabrics Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 manager 15/18] ui: node san: list NVMe over Fabrics controllers Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 manager 16/18] ui: san: show the NVMe host NQN of each node Thomas Lamprecht
2026-11-22  1:25 ` [PATCH v3 manager 17/18] ui: san: show that a namespace uses native multipath Thomas Lamprecht
2026-11-22  1:25 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261122012605.1848824-19-t.lamprecht@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal