public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Jakob Klocker <j.klocker@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-guest-common v4 4/7] vzdump: add error-behavior and max-retries options
Date: Fri, 20 Nov 2026 17:05:07 +0100	[thread overview]
Message-ID: <20261120160510.311796-5-j.klocker@proxmox.com> (raw)
In-Reply-To: <20261120160510.311796-1-j.klocker@proxmox.com>

Add two new backup job options to control what happens when a guest
backup fails:

- 'error-behavior' selects the behavior. 'ignore' keeps the current
  behavior and is the default. 'retry' queues the failed guest and
  retries it after the remaining guests have been backed up.
  'retry-immediately' retries the failed guest right away, before
  continuing with the next one.
- 'max-retries' limits how many times a failed guest backup is retried
  (1-10, default 5).

Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
---
 src/PVE/VZDump/Common.pm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
index 2cb48a3..2babd11 100644
--- a/src/PVE/VZDump/Common.pm
+++ b/src/PVE/VZDump/Common.pm
@@ -384,6 +384,24 @@ my $confdesc = {
         optional => 1,
         enum => ['legacy', 'data', 'metadata'],
     },
+    'error-behavior' => {
+        type => 'string',
+        description => "How to handle guest backup failures. 'ignore' does not retry,"
+            . " 'retry' retries failed guests after all other guests have been processed,"
+            . " 'retry-immediately' retries a failed guest before continuing with the next one.",
+        enum => ['ignore', 'retry', 'retry-immediately'],
+        optional => 1,
+        default => 'ignore',
+    },
+    'max-retries' => {
+        type => 'integer',
+        description => "Maximum number of times a failed guest backup is retried."
+            . " Only used if 'error-behavior' is not 'ignore'.",
+        minimum => 1,
+        maximum => 10,
+        optional => 1,
+        default => 5,
+    },
 };
 
 sub get_confdesc {
-- 
2.47.3





  parent reply	other threads:[~2026-11-20 16:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 16:05 [PATCH docs/guest-common/manager/storage/storage-plugin-examples v4 0/7] fix #6464: backup: add backup retry strategies Jakob Klocker
2026-11-20 16:05 ` [PATCH pve-storage-plugin-examples v4 1/7] backup provider example: run proxmox-perltidy Jakob Klocker
2026-11-20 16:05 ` [PATCH pve-storage-plugin-examples v4 2/7] backup provider example: reset per-guest state in backup_init Jakob Klocker
2026-11-20 16:05 ` [PATCH pve-storage v4 3/7] backup provider api: document repeated backup_init() calls on retries Jakob Klocker
2026-11-20 16:05 ` Jakob Klocker [this message]
2026-11-20 16:05 ` [PATCH pve-manager v4 5/7] fix #6464: vzdump: add retry strategies for failed guest backups Jakob Klocker
2026-11-20 16:05 ` [PATCH pve-manager v4 6/7] ui: backup: add error behavior and retry options Jakob Klocker
2026-11-20 16:05 ` [PATCH pve-docs v4 7/7] vzdump: document backup " Jakob Klocker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120160510.311796-5-j.klocker@proxmox.com \
    --to=j.klocker@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal