public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager/proxmox-widget-toolkit 0/2] ui: guest summary: fix the status panel being cut off
Date: Fri, 20 Nov 2026 16:15:12 +0100	[thread overview]
Message-ID: <20261120151518.3386028-1-d.csapak@proxmox.com> (raw)

With the unique ID row, the status panel of a container no longer fits
into the fixed height it shares with the notes, so its last rows (e.g.
the 'More' button of the IPs) are cut off.

The pve-manager patch lets the status panel set the height of that row
and keeps a minimum height for the notes, which still scroll instead of
growing the row.

Since the row can now be taller than the charts next to it, the charts
of the next row got caught on it with multiple columns and ended up in
the wrong column. The widget-toolkit patch fixes that for all column
layouts that use updateColumnWidth by starting each row at the left. It
does so with 'columnCount', an undocumented, internal property of the
ExtJS column layout.

The pve-manager patch needs the widget-toolkit patch for a correct
chart layout with multiple columns.

Alternatively we could of course increase the height of all panels,
but that would was space for guests without a guest agent for example.

proxmox-widget-toolkit:

Dominik Csapak (1):
  utils: update column width: start each row at the left

 src/Utils.js | 5 +++++
 1 file changed, 5 insertions(+)


pve-manager:

Dominik Csapak (1):
  ui: guest summary: let the status panel set the height of its row

 www/manager6/panel/GuestStatusView.js | 4 ++++
 www/manager6/panel/GuestSummary.js    | 6 ++++--
 2 files changed, 8 insertions(+), 2 deletions(-)


Summary over all repositories:
  3 files changed, 13 insertions(+), 2 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-11-20 15:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 15:15 Dominik Csapak [this message]
2026-11-20 15:15 ` [PATCH proxmox-widget-toolkit 1/2] utils: update column width: start each row at the left Dominik Csapak
2026-11-20 15:15 ` [PATCH pve-manager 2/2] ui: guest summary: let the status panel set the height of its row Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120151518.3386028-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal