public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH-SERIES qemu-server/container 0/3] fix #8354: config: gracefully handle empty 'running-nets-host-mtu'
Date: Fri, 20 Nov 2026 12:19:15 +0100	[thread overview]
Message-ID: <20261120111949.71436-1-f.ebner@proxmox.com> (raw)

For a VM without any VirtIO NICs (or if failing to query via QMP), the
result from get_nets_host_mtu() is an empty string. The schema
verification when writing out the configuration is currently
incomplete and for example, does not check the 'pattern' of a
property. The result verification for a 'qm config' command uses
tighter checks, so it would run into an error for an empty value:
> 400 Result verification failed
> running-nets-host-mtu: value does not match the regex pattern

Avoid writing out an empty 'running-nets-host-mtu' value to the
configuration and ignore it upon parsing to unbreak already written
out values.

Also add a reminder to tighten the checks for a future major release
to avoid such issues in the future.

qemu-server:

Fiona Ebner (2):
  fix #8354: config: gracefully handle empty 'running-nets-host-mtu'
  config: check type: add reminder to improve checks for major release

 src/PVE/QemuConfig.pm | 2 +-
 src/PVE/QemuServer.pm | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)


container:

Fiona Ebner (1):
  config: check type: add reminder to improve checks for major release

 src/PVE/LXC/Config.pm | 1 +
 1 file changed, 1 insertion(+)


Summary over all repositories:
  3 files changed, 7 insertions(+), 1 deletions(-)

-- 
Generated by git-murpp 0.5.0




             reply	other threads:[~2026-11-20 11:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 11:19 Fiona Ebner [this message]
2026-11-20 11:19 ` [PATCH qemu-server 1/3] fix #8354: config: gracefully handle empty 'running-nets-host-mtu' Fiona Ebner
2026-11-20 11:19 ` [PATCH qemu-server 2/3] config: check type: add reminder to improve checks for major release Fiona Ebner
2026-11-20 11:19 ` [PATCH container 3/3] " Fiona Ebner
2026-11-20 12:00 ` applied: [PATCH-SERIES qemu-server/container 0/3] fix #8354: config: gracefully handle empty 'running-nets-host-mtu' Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120111949.71436-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal