public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH cluster v4 04/41] pmxcfs: quorum: record the corosync membership
Date: Thu, 19 Nov 2026 11:33:50 +0100	[thread overview]
Message-ID: <20261119103551.1666964-5-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20261119103551.1666964-1-t.lamprecht@proxmox.com>

That the cluster is quorate does not tell a service whether all nodes of
the corosync membership have also taken part in the synchronization of
that service. To check this, the service needs to know which nodes are
in the membership. Record the node IDs from each quorum notification of
corosync next to the quorate flag, and clear them when the connection to
corosync is lost.

A reader gets a copy of the list. The loop thread can then compare the
corosync membership with the members of a dfsm group without holding the
status lock. Nothing reads the list yet.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

changes v3 -> v4:
* record the membership in the status, next to the quorate flag, instead
  of passing it to a listener: the cluster ID check reads it each time
  it runs and needs no notification; subject changed accordingly
* commit message: plainer wording, same content

changes v2 -> v3:
* comment: the array is only valid during the call

 src/pmxcfs/quorum.c | 13 +++++++++----
 src/pmxcfs/status.c | 23 +++++++++++++++++++++++
 src/pmxcfs/status.h |  7 +++++++
 3 files changed, 39 insertions(+), 4 deletions(-)

diff --git a/src/pmxcfs/quorum.c b/src/pmxcfs/quorum.c
index 0ac3cfe..7d87414 100644
--- a/src/pmxcfs/quorum.c
+++ b/src/pmxcfs/quorum.c
@@ -41,6 +41,11 @@ typedef struct {
     quorum_handle_t handle;
 } qs_private_t;
 
+static void quorum_set(uint32_t quorate, gboolean quiet, const uint32_t *nodeids, size_t count) {
+    cfs_set_quorate(quorate, quiet);
+    cfs_set_quorum_members(nodeids, count);
+}
+
 static void quorum_notification_fn(
     quorum_handle_t handle,
     uint32_t quorate,
@@ -64,7 +69,7 @@ static void quorum_notification_fn(
         return;
     }
 
-    cfs_set_quorate(quorate, FALSE);
+    quorum_set(quorate, FALSE, view_list, view_list_entries);
 }
 
 static quorum_callbacks_t quorum_callbacks = {
@@ -80,7 +85,7 @@ static gboolean service_quorum_finalize(cfs_service_t *service, gpointer context
 
     cs_error_t result;
 
-    cfs_set_quorate(0, TRUE);
+    quorum_set(0, TRUE, NULL, 0);
 
     result = quorum_finalize(handle);
     private->handle = 0;
@@ -150,7 +155,7 @@ static int service_quorum_initialize(cfs_service_t *service, gpointer context) {
     return quorum_fd;
 
 err_finalize:
-    cfs_set_quorate(0, FALSE);
+    quorum_set(0, FALSE, NULL, 0);
     quorum_finalize(handle);
 err_reset_handle:
     private
@@ -185,7 +190,7 @@ loop:
 
     cfs_critical("quorum_dispatch failed: %s", cs_strerror(result));
 
-    cfs_set_quorate(0, FALSE);
+    quorum_set(0, FALSE, NULL, 0);
     quorum_finalize(handle);
     private->handle = 0;
     return FALSE;
diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
index 8538d8b..bbfa88e 100644
--- a/src/pmxcfs/status.c
+++ b/src/pmxcfs/status.c
@@ -132,6 +132,8 @@ typedef struct {
     time_t start_time;
 
     uint32_t quorate;
+    uint32_t *quorum_members;
+    size_t quorum_members_len;
 
     cfs_clinfo_t *clinfo;
     uint32_t clinfo_version;
@@ -2000,6 +2002,27 @@ gboolean cfs_is_quorate(void) {
     return res;
 }
 
+void cfs_set_quorum_members(const uint32_t *nodeids, size_t count) {
+    g_return_if_fail(!count || nodeids != NULL);
+
+    g_mutex_lock(&mutex);
+    g_free(cfs_status.quorum_members);
+    cfs_status.quorum_members = count ? g_memdup2(nodeids, count * sizeof(*nodeids)) : NULL;
+    cfs_status.quorum_members_len = count;
+    g_mutex_unlock(&mutex);
+}
+
+uint32_t *cfs_get_quorum_members(size_t *count) {
+    g_return_val_if_fail(count != NULL, NULL);
+
+    g_mutex_lock(&mutex);
+    *count = cfs_status.quorum_members_len;
+    uint32_t *res = g_memdup2(cfs_status.quorum_members, *count * sizeof(*res));
+    g_mutex_unlock(&mutex);
+
+    return res;
+}
+
 void cfs_set_quorate(uint32_t quorate, gboolean quiet) {
     g_mutex_lock(&mutex);
 
diff --git a/src/pmxcfs/status.h b/src/pmxcfs/status.h
index 709ef64..a757326 100644
--- a/src/pmxcfs/status.h
+++ b/src/pmxcfs/status.h
@@ -69,6 +69,13 @@ void cfs_set_quorate(uint32_t quorate, gboolean quiet);
 
 gboolean cfs_is_quorate(void);
 
+/* the node IDs of the corosync membership as of the last quorum notification, none while not
+ * connected to corosync */
+void cfs_set_quorum_members(const uint32_t *nodeids, size_t count);
+
+/* a copy of them, to free with g_free() */
+uint32_t *cfs_get_quorum_members(size_t *count);
+
 GHashTable *vmlist_hash_new(void);
 
 gboolean vmlist_hash_insert_vm(
-- 
2.47.3





  parent reply	other threads:[~2026-11-19 10:35 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 10:33 [PATCH cluster/guest-common/qemu-server/container/manager/docs v4 00/41] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht
2026-11-19 10:33 ` [PATCH cluster v4 01/41] pmxcfs: reject changes to the cluster ID file from user space Thomas Lamprecht
2026-11-19 10:33 ` [PATCH cluster v4 02/41] pmxcfs: generate a cluster ID on standalone nodes Thomas Lamprecht
2026-11-19 10:33 ` [PATCH cluster v4 03/41] pmxcfs: dfsm: add a callback that runs once all members are in sync Thomas Lamprecht
2026-11-19 10:33 ` Thomas Lamprecht [this message]
2026-11-19 10:33 ` [PATCH cluster v4 05/41] pmxcfs: dcdb: generate the cluster ID once the cluster is " Thomas Lamprecht
2026-11-19 10:33 ` [PATCH cluster v4 06/41] cluster: add helper to read the cluster ID Thomas Lamprecht
2026-11-19 10:33 ` [PATCH cluster v4 07/41] pmxcfs: allow removing the cluster ID file in forced local mode Thomas Lamprecht
2026-11-19 10:33 ` [PATCH guest-common v4 08/41] guest identity: add helpers for the guest uid and registration time Thomas Lamprecht
2026-11-19 10:33 ` [PATCH guest-common v4 09/41] abstract config: assign a guest identity and keep it on config writes Thomas Lamprecht
2026-11-19 10:33 ` [PATCH guest-common v4 10/41] abstract config: let the VMID reservation return the previous state Thomas Lamprecht
2026-11-19 10:33 ` [PATCH guest-common v4 11/41] guest identity: allow adopting a uid that is unused in the cluster Thomas Lamprecht
2026-11-19 10:33 ` [PATCH guest-common v4 12/41] migrate: add shared helpers for the identity command of the migration tunnel Thomas Lamprecht
2026-11-19 10:33 ` [PATCH guest-common v4 13/41] vzdump: notes template: list the uid variable Thomas Lamprecht
2026-11-19 10:34 ` [PATCH qemu-server v4 14/41] api: restore: release the VMID if a restore to an unused VMID fails Thomas Lamprecht
2026-11-19 10:34 ` [PATCH qemu-server v4 15/41] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-19 10:34 ` [PATCH qemu-server v4 16/41] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-19 10:34 ` [PATCH qemu-server v4 17/41] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-19 10:34 ` [PATCH qemu-server v4 18/41] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-19 10:34 ` [PATCH qemu-server v4 19/41] api: status: return the guest uid Thomas Lamprecht
2026-11-19 10:34 ` [PATCH container v4 20/41] restore: decide by the reservation whether the container is new Thomas Lamprecht
2026-11-19 10:34 ` [PATCH container v4 21/41] config: add read-only meta property with the creation time Thomas Lamprecht
2026-11-19 10:34 ` [PATCH container v4 22/41] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-19 10:34 ` [PATCH container v4 23/41] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-19 10:34 ` [PATCH container v4 24/41] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-19 10:34 ` [PATCH container v4 25/41] restore: refuse overwriting a container with another guest's backup Thomas Lamprecht
2026-11-19 10:34 ` [PATCH container v4 26/41] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-19 10:34 ` [PATCH container v4 27/41] api: status: return the guest uid Thomas Lamprecht
2026-11-19 10:34 ` [PATCH manager v4 28/41] api: cluster resources: add guest uid and registration time Thomas Lamprecht
2026-11-19 10:34 ` [PATCH manager v4 29/41] api: cluster status: add cluster ID Thomas Lamprecht
2026-11-19 12:32   ` Lukas Wagner
2026-11-19 12:51     ` Thomas Lamprecht
2026-11-19 10:34 ` [PATCH manager v4 30/41] ui: datacenter summary: show the " Thomas Lamprecht
2026-11-19 10:34 ` [PATCH manager v4 31/41] ui: restore: allow overwriting a guest with a backup of another guest Thomas Lamprecht
2026-11-19 10:34 ` [PATCH manager v4 32/41] ui: migrate: refuse target nodes that would drop the guest identity Thomas Lamprecht
2026-11-19 10:34 ` [PATCH manager v4 33/41] ui: guest summary: show " Thomas Lamprecht
2026-11-19 10:34 ` [PATCH manager v4 34/41] api: bulk migrate: refuse targets that would drop " Thomas Lamprecht
2026-11-19 10:34 ` [PATCH manager v4 35/41] vzdump: notes template: add the guest uid as variable Thomas Lamprecht
2026-11-19 10:34 ` [PATCH docs v4 36/41] vzdump: restore: describe what a failed restore can leave behind Thomas Lamprecht
2026-11-19 10:34 ` [PATCH docs v4 37/41] vzdump: describe the guest identity of VMs and containers Thomas Lamprecht
2026-11-19 10:34 ` [PATCH docs v4 38/41] pvecm: document the cluster ID and how to get a new one Thomas Lamprecht
2026-11-19 10:34 ` [PATCH docs v4 39/41] qm: configuration: describe the read-only meta property Thomas Lamprecht
2026-11-19 10:34 ` [PATCH docs v4 40/41] pct: " Thomas Lamprecht
2026-11-19 10:34 ` [PATCH docs v4 41/41] vzdump: notes: document the uid template variable Thomas Lamprecht
2026-11-19 14:46 ` [PATCH cluster/guest-common/qemu-server/container/manager/docs v4 00/41] fix #7846: guest identity (uid) and cluster ID Dominik Csapak
2026-11-19 19:49 ` superseded: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119103551.1666964-5-t.lamprecht@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal