From: Daniel Kral <d.kral@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH ha-manager v4 10/17] lrm: rename update_lrm_status to flush_lrm_status
Date: Wed, 18 Nov 2026 15:44:55 +0100 [thread overview]
Message-ID: <20261118144502.231134-11-d.kral@proxmox.com> (raw)
In-Reply-To: <20261118144502.231134-1-d.kral@proxmox.com>
Make the method name similar to PVE::HA::Manager::flush_manager_status
as the term "flush" is more telling about the method writing something
out than the term "update" which could be an update in any direction.
Signed-off-by: Daniel Kral <d.kral@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>
---
src/PVE/HA/LRM.pm | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/PVE/HA/LRM.pm b/src/PVE/HA/LRM.pm
index d52b95a1..c50fdcb4 100644
--- a/src/PVE/HA/LRM.pm
+++ b/src/PVE/HA/LRM.pm
@@ -149,7 +149,7 @@ sub shutdown_request {
$self->{shutdown_request} = $haenv->get_time();
- eval { $self->update_lrm_status() or die "not quorate?\n"; };
+ eval { $self->flush_lrm_status() or die "not quorate?\n"; };
if (my $err = $@) {
$haenv->log('err', "unable to update lrm status file - $err");
}
@@ -180,7 +180,7 @@ sub set_local_status {
$self->{status} = $new;
}
-sub update_lrm_status {
+sub flush_lrm_status {
my ($self) = @_;
my $haenv = $self->{haenv};
@@ -359,7 +359,7 @@ sub work {
my $haenv = $self->{haenv};
if (!$wrote_lrm_status_at_startup) {
- if ($self->update_lrm_status()) {
+ if ($self->flush_lrm_status()) {
$wrote_lrm_status_at_startup = 1;
} else {
# do nothing
@@ -484,7 +484,7 @@ sub work {
return 0 if $self->{shutdown_request};
- $self->update_lrm_status();
+ $self->flush_lrm_status();
$haenv->sleep(5);
@@ -552,7 +552,7 @@ sub work {
$haenv->log('err', "got unexpected error - $err");
}
- $self->update_lrm_status();
+ $self->flush_lrm_status();
return 0 if $shutdown;
@@ -630,7 +630,7 @@ sub work {
$haenv->log('err', "got unexpected error - $err");
}
- $self->update_lrm_status();
+ $self->flush_lrm_status();
return 0 if $exit_lrm;
--
2.47.3
next prev parent reply other threads:[~2026-11-18 14:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 14:44 [PATCH-SERIES ha-manager v4 00/17] some sid parsing and LRM speedup improvements Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 01/17] resources: remove commented ipaddr resource type Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 02/17] tree-wide: use the term vmid instead of name when referring to VMs/CTs Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 03/17] tree-wide: remove unused return values at parse_sid callsites Daniel Kral
2026-11-18 15:20 ` Michael Köppl
2026-11-18 14:44 ` [PATCH ha-manager v4 04/17] config: make update_single_resource_config_inplace only allow sids Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 05/17] make parse_sid always return an array Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 06/17] config: use early returns in parse_sid Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 07/17] config: introduce separate parse_vmid_or_sid helper subroutine Daniel Kral
2026-11-18 16:02 ` Michael Köppl
2026-11-18 14:44 ` [PATCH ha-manager v4 08/17] drop the unmodified sid return array entry value from parse_sid Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 09/17] lrm: catch and report dies while the LRM is in maintenance state Daniel Kral
2026-11-18 16:12 ` Michael Köppl
2026-11-18 14:44 ` Daniel Kral [this message]
2026-11-18 14:44 ` [PATCH ha-manager v4 11/17] lrm: rename update_service_status to update_lrm_status Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 12/17] lrm: document and initialize LRM instance properties Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 13/17] lrm: update the service status once per work iteration Daniel Kral
2026-11-18 14:44 ` [PATCH ha-manager v4 14/17] lrm: read service config " Daniel Kral
2026-11-18 14:45 ` [PATCH ha-manager v4 15/17] lrm: compute valid service uids hash set " Daniel Kral
2026-11-18 14:45 ` [PATCH ha-manager v4 16/17] lrm: resource_command_finished: avoid writing stale LRM results Daniel Kral
2026-11-18 14:45 ` [PATCH ha-manager v4 17/17] lrm: prune stale LRM results once per work iteration Daniel Kral
2026-11-18 20:39 ` applied: [PATCH-SERIES ha-manager v4 00/17] some sid parsing and LRM speedup improvements Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118144502.231134-11-d.kral@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox