public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: David Riley <d.riley@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-network v4 3/6] fix #7294: sdn: vnet: update pool members on vnet migration and deletion
Date: Wed, 18 Nov 2026 12:57:54 +0100	[thread overview]
Message-ID: <20261118115757.94919-4-d.riley@proxmox.com> (raw)
In-Reply-To: <20261118115757.94919-1-d.riley@proxmox.com>

Update or remove corresponding resource pool allocations in user.cfg
whenever a VNet is altered or deleted. This prevents stale paths and
dangling references from breaking the configuration integrity.

Signed-off-by: David Riley <d.riley@proxmox.com>

Link: https://bugzilla.proxmox.com/show_bug.cgi?id=7294
---
 src/PVE/Network/SDN.pm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
index 9373ec3..7a4a9e3 100644
--- a/src/PVE/Network/SDN.pm
+++ b/src/PVE/Network/SDN.pm
@@ -256,12 +256,18 @@ sub cleanup_access_control {
 
     if (@$vnet_move_paths) {
         PVE::AccessControl::migrate_sdn_resource_access($vnet_move_paths);
+        PVE::AccessControl::migrate_vnet_zone_in_pool($vnet_move_paths);
     }
 
     my @paths_to_delete = (@$vnet_delete_paths, @$route_map_paths, @$generic_paths);
+
     if (@paths_to_delete) {
         PVE::AccessControl::remove_sdn_resource_access(\@paths_to_delete);
     }
+
+    if (@$vnet_delete_paths) {
+        PVE::AccessControl::remove_vnets_from_pool($vnet_delete_paths);
+    }
 }
 
 sub diff_generic_resources {
-- 
2.47.3





  parent reply	other threads:[~2026-11-18 11:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 11:57 [PATCH access-control/manager/network v4 0/6] fix #7294: pool: add SDN VNets as pool members David Riley
2026-11-18 11:57 ` [PATCH pve-access-control v4 1/6] rpcenv: add SDN.Allocate to modify permission check David Riley
2026-11-18 11:57 ` [PATCH pve-network v4 2/6] sdn: register api formats for zones and vnets David Riley
2026-11-18 11:57 ` David Riley [this message]
2026-11-18 11:57 ` [PATCH pve-manager v4 4/6] ui: replace var with let to match style guide for variable declaration David Riley
2026-11-18 11:57 ` [PATCH pve-manager v4 5/6] fix #7294: api: pool: add SDN VNets as pool members David Riley
2026-11-18 11:57 ` [PATCH pve-manager v4 6/6] fix #7294: ui: " David Riley
2026-11-19 12:49 ` superseded: [PATCH access-control/manager/network v4 0/6] fix #7294: " David Riley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118115757.94919-4-d.riley@proxmox.com \
    --to=d.riley@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal