public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox v2 04/63] notify: use ConfigDigest instead of raw byte arrays
Date: Wed, 18 Nov 2026 10:42:48 +0100	[thread overview]
Message-ID: <20261118094348.273646-5-l.wagner@proxmox.com> (raw)
In-Reply-To: <20261118094348.273646-1-l.wagner@proxmox.com>

The proxmox-config-digest crate did not exist when proxmox-notify was
written, hence it used raw byte slices for checking the digest.

This is a breaking change; users of proxmox-notify need to be adapted.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---

Notes:
    Changes since v1:
      - use ConfigDigest::detect_motification

 proxmox-notify/Cargo.toml          |  2 +-
 proxmox-notify/src/api/gotify.rs   |  9 ++++---
 proxmox-notify/src/api/matcher.rs  | 43 +++++++++++++++++-------------
 proxmox-notify/src/api/mod.rs      | 17 +++++-------
 proxmox-notify/src/api/sendmail.rs |  9 ++++---
 proxmox-notify/src/api/smtp.rs     |  9 ++++---
 proxmox-notify/src/api/webhook.rs  |  9 ++++---
 proxmox-notify/src/config.rs       |  9 ++++---
 proxmox-notify/src/lib.rs          |  5 ++--
 9 files changed, 60 insertions(+), 52 deletions(-)

diff --git a/proxmox-notify/Cargo.toml b/proxmox-notify/Cargo.toml
index 6796c2915..8968a14f8 100644
--- a/proxmox-notify/Cargo.toml
+++ b/proxmox-notify/Cargo.toml
@@ -19,7 +19,6 @@ http = { workspace = true, optional = true }
 lettre = { workspace = true, optional = true }
 tracing.workspace = true
 mail-parser = { workspace = true, optional = true }
-openssl.workspace = true
 percent-encoding = { workspace = true, optional = true }
 regex.workspace = true
 serde = { workspace = true, features = ["derive"] }
@@ -29,6 +28,7 @@ thiserror.workspace = true
 
 proxmox-api-macro.workspace = true
 proxmox-base64 = { workspace = true, optional = true }
+proxmox-config-digest = { workspace = true, features = ["openssl"] }
 proxmox-http = { workspace = true, features = ["client-sync"], optional = true }
 proxmox-http-error.workspace = true
 proxmox-human-byte.workspace = true
diff --git a/proxmox-notify/src/api/gotify.rs b/proxmox-notify/src/api/gotify.rs
index 5155fd2c8..c3149c152 100644
--- a/proxmox-notify/src/api/gotify.rs
+++ b/proxmox-notify/src/api/gotify.rs
@@ -1,3 +1,4 @@
+use proxmox_config_digest::ConfigDigest;
 use proxmox_http_error::HttpError;
 
 use crate::Config;
@@ -78,7 +79,7 @@ pub fn update_endpoint(
     endpoint_config_updater: GotifyConfigUpdater,
     private_endpoint_config_updater: GotifyPrivateConfigUpdater,
     delete: Option<&[DeleteableGotifyProperty]>,
-    digest: Option<&[u8]>,
+    digest: Option<ConfigDigest>,
 ) -> Result<(), HttpError> {
     super::verify_digest(config, digest)?;
 
@@ -220,7 +221,7 @@ mod tests {
                 Default::default(),
                 Default::default(),
                 None,
-                Some(&[0; 32])
+                Some(ConfigDigest::from([0; 32]))
             )
             .is_err()
         );
@@ -233,7 +234,7 @@ mod tests {
         let mut config = empty_config();
         add_default_gotify_endpoint(&mut config)?;
 
-        let digest = config.digest;
+        let digest = config.digest.clone();
 
         update_endpoint(
             &mut config,
@@ -247,7 +248,7 @@ mod tests {
                 token: Some("changedtoken".into()),
             },
             None,
-            Some(&digest),
+            Some(digest),
         )?;
 
         let endpoint = get_endpoint(&config, "gotify-endpoint")?;
diff --git a/proxmox-notify/src/api/matcher.rs b/proxmox-notify/src/api/matcher.rs
index 84131be3c..3302c2c31 100644
--- a/proxmox-notify/src/api/matcher.rs
+++ b/proxmox-notify/src/api/matcher.rs
@@ -1,3 +1,4 @@
+use proxmox_config_digest::ConfigDigest;
 use proxmox_http_error::HttpError;
 
 use crate::Config;
@@ -105,7 +106,7 @@ pub fn update_matcher(
     name: &str,
     matcher_updater: MatcherConfigUpdater,
     delete: Option<&[DeleteableMatcherProperty]>,
-    digest: Option<&[u8]>,
+    digest: Option<ConfigDigest>,
 ) -> Result<(), HttpError> {
     super::verify_digest(config, digest)?;
 
@@ -251,7 +252,7 @@ matcher: matcher2
                 "matcher1",
                 Default::default(),
                 None,
-                Some(&[0u8; 32])
+                Some(ConfigDigest::from([0u8; 32]))
             )
             .is_err()
         );
@@ -266,7 +267,7 @@ matcher: matcher2
 
         let mut config = config_with_two_matchers();
 
-        let digest = config.digest;
+        let digest = config.digest.clone();
 
         update_matcher(
             &mut config,
@@ -282,7 +283,7 @@ matcher: matcher2
                 ..Default::default()
             },
             None,
-            Some(&digest),
+            Some(digest.clone()),
         )?;
 
         let matcher = get_matcher(&config, "matcher1")?;
@@ -303,7 +304,7 @@ matcher: matcher2
                 DeleteableMatcherProperty::Target,
                 DeleteableMatcherProperty::Comment,
             ]),
-            Some(&digest),
+            Some(digest),
         )?;
 
         let matcher = get_matcher(&config, "matcher1")?;
@@ -323,7 +324,7 @@ matcher: matcher2
     fn test_matcher_update() -> Result<(), HttpError> {
         let mut config = config_with_two_matchers();
 
-        let digest = config.digest;
+        let digest = config.digest.clone();
 
         update_matcher(
             &mut config,
@@ -335,7 +336,7 @@ matcher: matcher2
                 ..Default::default()
             },
             None,
-            Some(&digest),
+            Some(digest.clone()),
         )?;
 
         let matcher = get_matcher(&config, "matcher1")?;
@@ -352,7 +353,7 @@ matcher: matcher2
                 DeleteableMatcherProperty::Comment,
                 DeleteableMatcherProperty::Expression,
             ]),
-            Some(&digest),
+            Some(digest),
         )?;
 
         let matcher = get_matcher(&config, "matcher1")?;
@@ -378,7 +379,7 @@ matcher: matcher2
     #[cfg(feature = "legacy-matchers")]
     fn test_update_matcher_mutually_exclusive_with_expression() -> Result<(), HttpError> {
         let mut config = config_with_two_matchers();
-        let digest = config.digest;
+        let digest = config.digest.clone();
 
         let proto = MatcherConfigUpdater {
             expression: Some(valid_expression_string()),
@@ -388,17 +389,23 @@ matcher: matcher2
         let mut updater = proto.clone();
         updater.match_field = Some(vec!["exact:foo=bar".parse().unwrap()]);
 
-        assert!(update_matcher(&mut config, "matcher1", updater, None, Some(&digest),).is_err());
+        assert!(
+            update_matcher(&mut config, "matcher1", updater, None, Some(digest.clone()),).is_err()
+        );
 
         let mut updater = proto.clone();
         updater.match_calendar = Some(vec!["mon..sun 12-13".parse().unwrap()]);
 
-        assert!(update_matcher(&mut config, "matcher1", updater, None, Some(&digest),).is_err());
+        assert!(
+            update_matcher(&mut config, "matcher1", updater, None, Some(digest.clone()),).is_err()
+        );
 
         let mut updater = proto.clone();
         updater.match_severity = Some(vec!["info,warning".parse().unwrap()]);
 
-        assert!(update_matcher(&mut config, "matcher1", updater, None, Some(&digest),).is_err());
+        assert!(
+            update_matcher(&mut config, "matcher1", updater, None, Some(digest.clone()),).is_err()
+        );
 
         Ok(())
     }
@@ -406,7 +413,7 @@ matcher: matcher2
     #[test]
     fn test_update_invalid_expression() -> Result<(), HttpError> {
         let mut config = config_with_two_matchers();
-        let digest = config.digest;
+        let digest = config.digest.clone();
 
         assert!(
             update_matcher(
@@ -417,7 +424,7 @@ matcher: matcher2
                     ..Default::default()
                 },
                 None,
-                Some(&digest),
+                Some(digest),
             )
             .is_err()
         );
@@ -437,7 +444,7 @@ matcher: matcher2
     #[test]
     fn test_update_minifies_pretty_printed_expression() -> Result<(), HttpError> {
         let mut config = config_with_two_matchers();
-        let digest = config.digest;
+        let digest = config.digest.clone();
 
         let expr = nested_expression();
         let pretty = serde_json::to_string_pretty(&expr).unwrap();
@@ -451,7 +458,7 @@ matcher: matcher2
                 ..Default::default()
             },
             None,
-            Some(&digest),
+            Some(digest),
         )?;
 
         let matcher = get_matcher(&config, "matcher1")?;
@@ -466,7 +473,7 @@ matcher: matcher2
     #[test]
     fn test_update_normalizes_expression_with_extra_whitespace() -> Result<(), HttpError> {
         let mut config = config_with_two_matchers();
-        let digest = config.digest;
+        let digest = config.digest.clone();
 
         // Same expression as `nested_expression`, but handwritten, with all sorts of
         // odd whitespace characters.
@@ -481,7 +488,7 @@ matcher: matcher2
                 ..Default::default()
             },
             None,
-            Some(&digest),
+            Some(digest),
         )?;
 
         let matcher = get_matcher(&config, "matcher1")?;
diff --git a/proxmox-notify/src/api/mod.rs b/proxmox-notify/src/api/mod.rs
index 7f823bc7c..9697f9f17 100644
--- a/proxmox-notify/src/api/mod.rs
+++ b/proxmox-notify/src/api/mod.rs
@@ -2,6 +2,7 @@ use std::collections::HashSet;
 
 use serde::{Deserialize, Serialize};
 
+use proxmox_config_digest::ConfigDigest;
 use proxmox_http_error::HttpError;
 use proxmox_schema::api;
 
@@ -132,17 +133,11 @@ pub fn get_targets(config: &Config) -> Result<Vec<Target>, HttpError> {
     Ok(targets)
 }
 
-fn verify_digest(config: &Config, digest: Option<&[u8]>) -> Result<(), HttpError> {
-    if let Some(digest) = digest {
-        if config.digest != *digest {
-            http_bail!(
-                BAD_REQUEST,
-                "detected modified configuration - file changed by other user? Try again."
-            );
-        }
-    }
-
-    Ok(())
+fn verify_digest(config: &Config, digest: Option<ConfigDigest>) -> Result<(), HttpError> {
+    config
+        .digest()
+        .detect_modification(digest.as_ref())
+        .map_err(|err| http_err!(BAD_REQUEST, "{err}"))
 }
 
 fn ensure_endpoint_exists(#[allow(unused)] config: &Config, name: &str) -> Result<(), HttpError> {
diff --git a/proxmox-notify/src/api/sendmail.rs b/proxmox-notify/src/api/sendmail.rs
index eaafd0012..2d54608cd 100644
--- a/proxmox-notify/src/api/sendmail.rs
+++ b/proxmox-notify/src/api/sendmail.rs
@@ -1,3 +1,4 @@
+use proxmox_config_digest::ConfigDigest;
 use proxmox_http_error::HttpError;
 
 use crate::Config;
@@ -71,7 +72,7 @@ pub fn update_endpoint(
     name: &str,
     updater: SendmailConfigUpdater,
     delete: Option<&[DeleteableSendmailProperty]>,
-    digest: Option<&[u8]>,
+    digest: Option<ConfigDigest>,
 ) -> Result<(), HttpError> {
     super::verify_digest(config, digest)?;
 
@@ -216,7 +217,7 @@ pub mod tests {
                     ..Default::default()
                 },
                 None,
-                Some(&[0; 32]),
+                Some(ConfigDigest::from([0; 32])),
             )
             .is_err()
         );
@@ -229,7 +230,7 @@ pub mod tests {
         let mut config = empty_config();
         add_sendmail_endpoint_for_test(&mut config, "sendmail-endpoint")?;
 
-        let digest = config.digest;
+        let digest = config.digest.clone();
 
         update_endpoint(
             &mut config,
@@ -243,7 +244,7 @@ pub mod tests {
                 ..Default::default()
             },
             None,
-            Some(&digest),
+            Some(digest),
         )?;
 
         let endpoint = get_endpoint(&config, "sendmail-endpoint")?;
diff --git a/proxmox-notify/src/api/smtp.rs b/proxmox-notify/src/api/smtp.rs
index 41a94581b..456cbc31e 100644
--- a/proxmox-notify/src/api/smtp.rs
+++ b/proxmox-notify/src/api/smtp.rs
@@ -1,3 +1,4 @@
+use proxmox_config_digest::ConfigDigest;
 use proxmox_http_error::HttpError;
 
 use crate::Config;
@@ -89,7 +90,7 @@ pub fn update_endpoint(
     updater: SmtpConfigUpdater,
     private_endpoint_config_updater: SmtpPrivateConfigUpdater,
     delete: Option<&[DeleteableSmtpProperty]>,
-    digest: Option<&[u8]>,
+    digest: Option<ConfigDigest>,
 ) -> Result<(), HttpError> {
     super::verify_digest(config, digest)?;
 
@@ -276,7 +277,7 @@ pub mod tests {
                 Default::default(),
                 Default::default(),
                 None,
-                Some(&[0; 32]),
+                Some(ConfigDigest::from([0; 32])),
             )
             .is_err()
         );
@@ -289,7 +290,7 @@ pub mod tests {
         let mut config = empty_config();
         add_smtp_endpoint_for_test(&mut config, "smtp-endpoint")?;
 
-        let digest = config.digest;
+        let digest = config.digest.clone();
 
         update_endpoint(
             &mut config,
@@ -308,7 +309,7 @@ pub mod tests {
             },
             Default::default(),
             None,
-            Some(&digest),
+            Some(digest),
         )?;
 
         let endpoint = get_endpoint(&config, "smtp-endpoint")?;
diff --git a/proxmox-notify/src/api/webhook.rs b/proxmox-notify/src/api/webhook.rs
index 1d29dcc89..e79eeb7e9 100644
--- a/proxmox-notify/src/api/webhook.rs
+++ b/proxmox-notify/src/api/webhook.rs
@@ -2,6 +2,7 @@
 //!
 //! All methods assume that the caller has already done any required permission checks.
 
+use proxmox_config_digest::ConfigDigest;
 use proxmox_http_error::HttpError;
 use proxmox_schema::property_string::PropertyString;
 
@@ -136,7 +137,7 @@ pub fn update_endpoint(
     name: &str,
     config_updater: WebhookConfigUpdater,
     delete: Option<&[DeleteableWebhookProperty]>,
-    digest: Option<&[u8]>,
+    digest: Option<ConfigDigest>,
 ) -> Result<(), HttpError> {
     super::verify_digest(config, digest)?;
 
@@ -337,7 +338,7 @@ mod tests {
                 "webhook-endpoint",
                 Default::default(),
                 None,
-                Some(&[0; 32])
+                Some(ConfigDigest::from([0; 32]))
             )
             .is_err()
         );
@@ -350,7 +351,7 @@ mod tests {
         let mut config = empty_config();
         add_default_webhook_endpoint(&mut config)?;
 
-        let digest = config.digest;
+        let digest = config.digest.clone();
 
         update_endpoint(
             &mut config,
@@ -371,7 +372,7 @@ mod tests {
                 ..Default::default()
             },
             None,
-            Some(&digest),
+            Some(digest),
         )?;
 
         let endpoint = get_endpoint(&config, "webhook-endpoint")?;
diff --git a/proxmox-notify/src/config.rs b/proxmox-notify/src/config.rs
index c280e8285..176bc46b7 100644
--- a/proxmox-notify/src/config.rs
+++ b/proxmox-notify/src/config.rs
@@ -1,5 +1,6 @@
 use std::sync::OnceLock;
 
+use proxmox_config_digest::ConfigDigest;
 use proxmox_schema::{ApiType, ObjectSchema};
 use proxmox_section_config::{SectionConfig, SectionConfigData, SectionConfigPlugin};
 
@@ -120,8 +121,8 @@ fn private_config_init() -> SectionConfig {
     config
 }
 
-pub fn config(raw_config: &str) -> Result<(SectionConfigData, [u8; 32]), Error> {
-    let digest = openssl::sha::sha256(raw_config.as_bytes());
+pub fn config(raw_config: &str) -> Result<(SectionConfigData, ConfigDigest), Error> {
+    let digest = ConfigDigest::from_slice(raw_config.as_bytes());
     let data = config_parser()
         .parse("notifications.cfg", raw_config)
         .map_err(Error::config_deserialization)?;
@@ -129,8 +130,8 @@ pub fn config(raw_config: &str) -> Result<(SectionConfigData, [u8; 32]), Error>
     Ok((data, digest))
 }
 
-pub fn private_config(raw_config: &str) -> Result<(SectionConfigData, [u8; 32]), Error> {
-    let digest = openssl::sha::sha256(raw_config.as_bytes());
+pub fn private_config(raw_config: &str) -> Result<(SectionConfigData, ConfigDigest), Error> {
+    let digest = ConfigDigest::from_slice(raw_config.as_bytes());
     let data = private_config_parser()
         .parse("priv/notifications.cfg", raw_config)
         .map_err(Error::config_deserialization)?;
diff --git a/proxmox-notify/src/lib.rs b/proxmox-notify/src/lib.rs
index 846e8315e..0a851239d 100644
--- a/proxmox-notify/src/lib.rs
+++ b/proxmox-notify/src/lib.rs
@@ -11,6 +11,7 @@ use serde_json::Value;
 use serde_json::json;
 use tracing::{error, info};
 
+use proxmox_config_digest::ConfigDigest;
 use proxmox_schema::api;
 use proxmox_section_config::SectionConfigData;
 use proxmox_uuid::Uuid;
@@ -204,7 +205,7 @@ impl Notification {
 pub struct Config {
     config: SectionConfigData,
     private_config: SectionConfigData,
-    digest: [u8; 32],
+    digest: ConfigDigest,
 }
 
 impl Config {
@@ -292,7 +293,7 @@ impl Config {
 
     /// Returns the SHA256 digest of the configuration.
     /// The digest is only computed once when the configuration deserialized.
-    pub fn digest(&self) -> &[u8; 32] {
+    pub fn digest(&self) -> &ConfigDigest {
         &self.digest
     }
 }
-- 
2.47.3





  parent reply	other threads:[~2026-11-18  9:45 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  9:42 [PATCH many v2 00/63] notify: maintenance, PDM preparations, queue + worker Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 01/63] notify: disallow `unsafe` code Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 02/63] notify: refactor error type Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 03/63] notify: move `Endpoint` trait to endpoint module as pub(crate) Lukas Wagner
2026-11-18  9:42 ` Lukas Wagner [this message]
2026-11-18  9:42 ` [PATCH proxmox v2 05/63] notify: remove static context and pass context as parameter Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 06/63] notify: matcher: drop unused field matcher verifiers Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 07/63] notify: introduce 'send-impl', 'api-impl' and 'api-types' features Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 08/63] notify: matcher: make matcher validation methods public Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 09/63] notify: matcher: stub CalendarMatcher::matches on wasm32 Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 10/63] notify: make SendmailEndpoint and SmtpEndpoint private types Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 11/63] notify: move `send`, `test_target` and `Bus` to new `send` module Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 12/63] notify: move Origin type to api_types module Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 13/63] notify: move Target " Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 14/63] notify: move Config to config module Lukas Wagner
2026-11-18  9:42 ` [PATCH proxmox v2 15/63] notify: move Notification and sub-types to `notification` module Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 16/63] notify: move schema module to api_types Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 17/63] notify: move check_matches from api_types::matcher to send::Bus Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 18/63] notify: move TemplateSource to context module Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 19/63] notify: config: cleanup helper names and visibility Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 20/63] notify: config: rename section config parser/writer methods Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 21/63] notify: config: pass builtins explicitly when parsing section config Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 22/63] notify: implement PartialEq for all Config types Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 23/63] notify: use typed SectionConfigData Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 24/63] notify: api: api types: rename Deleteable* -> Deletable* Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 25/63] notify: context: parse builtin config only once Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 26/63] notify: context: parse proxy config in trait impl, not at the callsite Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 27/63] notify: gate sub-modules with the appropriate feature flags Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 28/63] notify: fold mail-forwarder feature into send-impl Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 29/63] notify: forwarded mails: don't hardcode severity and metadata fields Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 30/63] notify: don't pass uid when instantiating forwarded mail notifications Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 31/63] notify: derive PartialEq for Notification type Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 32/63] notify: add getters for severity and fields on " Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 33/63] notify: add test suite for " Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 34/63] notify: serialize raw, forwarded mail content as base64 Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 35/63] notify: unify code paths for legacy-sendmail and regular notifications Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 36/63] notify: add backwards-compat note to Notification type Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 37/63] notify: remove 'test_target' API Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 38/63] notify: replace notification instantiation with builder pattern Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 39/63] notify: add send receipts Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 40/63] notify: make sure that template name matches SAFE_ID_REGEX Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 41/63] notify: implement notification queue submitter Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 42/63] notify: context: add read_config Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 43/63] notify: queue: add queue consumer Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox v2 44/63] notify: queue: add worker task Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-backup v2 45/63] notifications: don't ignore verification errors in legacy-sendmail mode Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-backup v2 46/63] notifications: adapt to proxmox-notify API changes Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-backup v2 47/63] api: notification: send test notification via proxmox_notify::send Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-backup v2 48/63] notifications: send all notifications via proxmox-notify's queue Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-perl-rs v2 49/63] pve: notify: adapt to changes in the public API of proxmox-notify Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-perl-rs v2 50/63] pve: notify: add `PVE::RS::Notify::enqueue` method Lukas Wagner
2026-11-18  9:43 ` [PATCH pve-cluster v2 51/63] notify: send notifications via notification queue Lukas Wagner
2026-11-18  9:43 ` [PATCH manager v2 52/63] vzdump: send legacy-sendmail notifications via simplified API Lukas Wagner
2026-11-18  9:43 ` [PATCH manager v2 53/63] debian: create notification queue directory via tmpfiles Lukas Wagner
2026-11-18  9:43 ` [PATCH manager v2 54/63] debian: add 'pve-notify-worker' as dependecy Lukas Wagner
2026-11-18  9:43 ` [PATCH manager v2 55/63] api: services: add 'pve-notify-worker' as known service Lukas Wagner
2026-11-18  9:43 ` [PATCH manager v2 56/63] services: request pve-notify-worker.service via Wants Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-mail-forward v2 57/63] forward mails via notification queue Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-mail-forward v2 58/63] use return code to signal permanent or temporary failure Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-mail-forward v2 59/63] limit size of mail read from stdin Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-mail-forward v2 60/63] cargo: move mail forwarder into a workspace member crate Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-mail-forward v2 61/63] add crate for code shared between the mail-forwarder and the worker Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-mail-forward v2 62/63] add pve-notify-worker crate and package Lukas Wagner
2026-11-18  9:43 ` [PATCH proxmox-mail-forward v2 63/63] debian: add versioned break for pve-manager and proxmox-backup-server Lukas Wagner
2026-11-18 21:44 ` [PATCH many v2 00/63] notify: maintenance, PDM preparations, queue + worker Thomas Lamprecht
2026-11-19 10:45   ` Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118094348.273646-5-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal