public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v2 18/36] tests: remote migration: check a failed command and an early tunnel end
Date: Tue, 17 Nov 2026 23:34:28 +0100	[thread overview]
Message-ID: <20261117223945.862914-19-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20261117223945.862914-1-t.lamprecht@proxmox.com>

With the uid taken over at the start of a remote migration, a config
left behind on the target would keep the uid of the VM in the target
cluster. Check that the target removes its reservation if the tunnel
closes before the config arrived, keeps a config that arrived, and
logs the error of a failed tunnel command.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

changes v1 -> v2:
* new in v2

 src/test/run_guest_identity_tests.pl | 84 ++++++++++++++++++++++++++++
 1 file changed, 84 insertions(+)

diff --git a/src/test/run_guest_identity_tests.pl b/src/test/run_guest_identity_tests.pl
index f755e1b6..727763f1 100755
--- a/src/test/run_guest_identity_tests.pl
+++ b/src/test/run_guest_identity_tests.pl
@@ -522,6 +522,90 @@ subtest 'remote migration, target side' => sub {
     );
     ok($replies->[1]->{success}, 'adopting fails: cleanup on quit succeeds');
     ok(!defined(configs()->{103}), 'adopting fails: reservation removed by the cleanup');
+
+    my $warnings = '';
+    local $SIG{__WARN__} = sub { $warnings .= $_[0]; };
+
+    ($replies, $output, $err) = run_mtunnel(104, [$identity_cmd, $cleanup_cmd]);
+    like(
+        $warnings,
+        qr/^failed to handle 'identity' command - unable to adopt the uid of the source guest/m,
+        'failed command: target task logs the error',
+    );
+
+    QemuServerTest::FakeCFS::reset();
+    $warnings = '';
+    ($replies, $output, $err) = run_mtunnel(104, [$identity_cmd]);
+    like($err, qr/mtunnel exited unexpectedly/, 'end before the config: tunnel fails');
+    ok($replies->[0]->{success}, 'end before the config: uid was taken over');
+    like(
+        $warnings,
+        qr/^tunnel closed before the config arrived, cleaning up$/m,
+        'end before the config: cleanup is logged',
+    );
+    ok(!defined(configs()->{104}),
+        'end before the config: reservation with the uid is removed');
+
+    QemuServerTest::FakeCFS::reset();
+    $warnings = '';
+    ($replies, $output, $err) = run_mtunnel(104, [$identity_cmd, $config_cmd]);
+    like($err, qr/mtunnel exited unexpectedly/, 'end after the config: tunnel fails');
+    unlike($warnings, qr/cleaning up/, 'end after the config: no cleanup');
+    like(configs()->{104}, qr/^lock: migrate$/m, 'end after the config: config is kept');
+
+    # the volume of a transfer is only known once the transfer is done
+    my $import_cmd = {
+        cmd => 'disk-import',
+        volname => 'vm-104-disk-0',
+        format => 'raw',
+        export_formats => 'raw+size',
+        storage => 'local',
+    };
+    my ($queries, $ends_after, $freed) = (0, 2, []);
+    my $storage_tunnel_module = Test::MockModule->new('PVE::StorageTunnel');
+    $storage_tunnel_module->mock(
+        handle_disk_import => sub {
+            my ($state) = @_;
+            $state->{disk_import} = { pid => 1 };
+            return {};
+        },
+        handle_query_disk_import => sub {
+            my ($state) = @_;
+            return { status => 'pending' } if ++$queries < $ends_after;
+            delete $state->{disk_import};
+            $state->{cleanup}->{volumes}->{'local:104/vm-104-disk-0.raw'} = 1;
+            return { status => 'complete' };
+        },
+    );
+    $storage_module->mock(
+        storage_check_enabled => sub { return 1; },
+        storage_config => sub { return { content => { images => 1 } }; },
+        vdisk_free => sub { push $freed->@*, $_[1]; },
+    );
+    my $rpcenv_module = Test::MockModule->new('PVE::RPCEnvironment');
+    $rpcenv_module->mock(check => sub { return 1; });
+
+    QemuServerTest::FakeCFS::reset();
+    $warnings = '';
+    ($replies, $output, $err) = run_mtunnel(104, [$import_cmd]);
+    ok($replies->[0]->{success}, 'transfer that ends: it starts') or diag(explain($replies));
+    is_deeply(
+        $freed,
+        ['local:104/vm-104-disk-0.raw'],
+        'transfer that ends: its volume is freed',
+    );
+    ok(!defined(configs()->{104}), 'transfer that ends: reservation is removed');
+
+    QemuServerTest::FakeCFS::reset();
+    ($queries, $ends_after, $freed, $warnings) = (0, 100, [], '');
+    ($replies, $output, $err) = run_mtunnel(104, [$import_cmd]);
+    like(
+        $warnings,
+        qr/^cleanup failed - a volume transfer is still running$/m,
+        'transfer that does not end: it is reported',
+    );
+    is_deeply($freed, [], 'transfer that does not end: nothing is freed');
+    ok(defined(configs()->{104}), 'transfer that does not end: reservation is kept');
 };
 
 subtest 'remote migration, source side' => sub {
-- 
2.47.3





  parent reply	other threads:[~2026-11-17 22:41 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 22:34 [PATCH cluster/guest-common/qemu-server/container/manager/docs v2 00/36] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht
2026-11-17 22:34 ` [PATCH cluster v2 01/36] pmxcfs: reject changes to the cluster ID file from user space Thomas Lamprecht
2026-11-17 22:34 ` [PATCH cluster v2 02/36] pmxcfs: generate a cluster ID on standalone nodes Thomas Lamprecht
2026-11-17 22:34 ` [PATCH cluster v2 03/36] pmxcfs: dfsm: add a callback that runs once all members are in sync Thomas Lamprecht
2026-11-17 22:34 ` [PATCH cluster v2 04/36] pmxcfs: quorum: pass the corosync membership to an optional listener Thomas Lamprecht
2026-11-17 22:34 ` [PATCH cluster v2 05/36] pmxcfs: dcdb: generate the cluster ID once the cluster is in sync Thomas Lamprecht
2026-11-17 22:34 ` [PATCH cluster v2 06/36] cluster: add helper to read the cluster ID Thomas Lamprecht
2026-11-17 22:34 ` [PATCH cluster v2 07/36] pmxcfs: allow removing the cluster ID file in forced local mode Thomas Lamprecht
2026-11-17 22:34 ` [PATCH guest-common v2 08/36] guest identity: add helpers for the guest uid and registration time Thomas Lamprecht
2026-11-17 22:34 ` [PATCH guest-common v2 09/36] abstract config: assign a guest identity and keep it on config writes Thomas Lamprecht
2026-11-17 22:34 ` [PATCH guest-common v2 10/36] abstract config: let the VMID reservation return the previous state Thomas Lamprecht
2026-11-17 22:34 ` [PATCH guest-common v2 11/36] guest identity: allow taking over a uid that is unused in the cluster Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 12/36] api: restore: release the VMID if a restore to an unused VMID fails Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 13/36] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 14/36] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 15/36] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 16/36] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 17/36] api: status: return the guest uid Thomas Lamprecht
2026-11-17 22:34 ` Thomas Lamprecht [this message]
2026-11-17 22:34 ` [PATCH container v2 19/36] config: add read-only meta property with the creation time Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 20/36] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 21/36] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 22/36] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 23/36] restore: refuse overwriting a container with another guest's backup Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 24/36] test: remote migration: check the cleanup of the target after failures Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 25/36] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 26/36] api: status: return the guest uid Thomas Lamprecht
2026-11-17 22:34 ` [PATCH manager v2 27/36] api: cluster resources: add guest uid and registration time Thomas Lamprecht
2026-11-17 22:34 ` [PATCH manager v2 28/36] api: cluster status: add cluster ID Thomas Lamprecht
2026-11-17 22:34 ` [PATCH manager v2 29/36] ui: restore: allow overwriting a guest with a backup of another guest Thomas Lamprecht
2026-11-17 22:34 ` [PATCH manager v2 30/36] ui: migrate: refuse target nodes that would drop the guest identity Thomas Lamprecht
2026-11-17 22:34 ` [PATCH manager v2 31/36] ui: guest summary: show " Thomas Lamprecht
2026-11-17 22:34 ` [PATCH manager v2 32/36] api: migrate all: refuse targets that would drop " Thomas Lamprecht
2026-11-17 22:34 ` [PATCH docs v2 33/36] vzdump: describe the guest identity of VMs and containers Thomas Lamprecht
2026-11-17 22:34 ` [PATCH docs v2 34/36] pvecm: document the cluster ID and how to get a new one Thomas Lamprecht
2026-11-17 22:34 ` [PATCH docs v2 35/36] qm: configuration: describe the read-only meta property Thomas Lamprecht
2026-11-17 22:34 ` [PATCH docs v2 36/36] pct: " Thomas Lamprecht
2026-11-18  5:57 ` superseded: [PATCH cluster/guest-common/qemu-server/container/manager/docs v2 00/36] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117223945.862914-19-t.lamprecht@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal