public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lucas Barros <lucasbarros.kam@gmail.com>
To: pve-devel@lists.proxmox.com
Cc: t.lamprecht@proxmox.com, Lucas Barros <lucasbarros.kam@gmail.com>
Subject: [PATCH manager v3 2/2] fix #6357: api: node dns: return all search domains
Date: Mon, 16 Nov 2026 10:31:08 -0300	[thread overview]
Message-ID: <20261116133000.6357-2-lucasbarros.kam@gmail.com> (raw)
In-Reply-To: <20261116133000.6357-0-lucasbarros.kam@gmail.com>

The DNS settings of a node with multiple search domains could be
written, but reading them back, for example in the node's DNS panel in
the web UI, only showed the first domain, so saving the dialog again
silently dropped the others.

Use the new reader from pve-common that keeps the whole search list.
The other users of the 'resolvconf' file, like the node certificate or
the guest DNS fallback, keep getting only the first domain.

Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
---

changes since v2:
* new in v3: only the node DNS API switches to the whole search list
* needs 1/2, so the libpve-common-perl dependency has to be bumped

This patch was prepared with the help of an LLM based coding assistant; I
reviewed the change and ran the tests from the cover letter myself.

 PVE/API2/Nodes.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index 1e2a96f1..7f0b029d 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -1621,7 +1621,7 @@ __PACKAGE__->register_method({
     code => sub {
         my ($param) = @_;
 
-        my $res = PVE::INotify::read_file('resolvconf');
+        my $res = PVE::INotify::read_resolv_conf_with_search_list();
 
         return $res;
     },
-- 
2.50.1 (Apple Git-155)




  parent reply	other threads:[~2026-11-16 13:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 13:31 [PATCH common/manager v3 0/2] fix #6357: show all search domains in the node DNS settings Lucas Barros
2026-11-16 13:31 ` [PATCH common v3 1/2] inotify: resolv.conf: add reader that keeps the whole search list Lucas Barros
2026-11-16 13:31 ` Lucas Barros [this message]
2026-11-18  1:42 ` partially-applied: [PATCH common/manager v3 0/2] fix #6357: show all search domains in the node DNS settings Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116133000.6357-2-lucasbarros.kam@gmail.com \
    --to=lucasbarros.kam@gmail.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal