From: Mark Atwood <mark@wolfssl.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH access-control v2 0/1] tickets: sign with the hash from datacenter.cfg
Date: Fri, 13 Nov 2026 03:06:51 +0000 [thread overview]
Message-ID: <20261113030652.3550-1-mark@wolfssl.com> (raw)
Create login, TFA, VNC and tunnel tickets with the hash that the new
'ticket-signature-hash' option of datacenter.cfg selects. Without the option
tickets are signed with SHA-1 as before.
This is the pve-access-control part of the v2 of "ticket: sign RSA tickets
with SHA-256". The pve-common part also affects Proxmox Mail Gateway, which
uses PVE::Ticket; this patch is PVE only.
Apply order across the repositories, all three are part of this series:
1. pve-common (2 patches)
2. pve-cluster (adds the datacenter.cfg option)
3. pve-access-control (reads the option and signs with it)
pve-common and pve-cluster are independent of each other. pve-access-control
needs both, but is harmless without them: it then keeps signing with SHA-1.
d/control: I did not bump the versioned dependencies, as the version numbers
depend on the release that contains the pve-common and pve-cluster changes.
They need to be bumped when applying.
Mixed clusters: nodes without pve-common 1/2 reject SHA-256 tickets, so the
option must only be set to 'sha256' once every node has that patch. The option
description says so. I did not add an automatic check against the node
versions (the new helpers in pve-cluster, 679cf2c, would allow one), as it
needs the release number that will contain 1/2. Happy to add one in
pve-manager's datacenter options update once that number is known.
Changes since v1: the pve-access-control part is new in v2. The separate CSRF
patch from v1 was applied already (07bb3b1) and is not part of this series.
Shannon asked for opt-in, so tickets are signed with the hash from the
datacenter configuration, which defaults to SHA-1. All other v1 review points
are in the pve-common cover letter.
v1: <CALkZksWBSdQa5AsvhmANGAJigcZ7FHPtgRgdu3JsRt9NX6vwSg@mail.gmail.com>
This is sent as a new thread, as is usual for a new version of a series.
Thanks to Shannon Sterz for the review of v1.
Mark Atwood (1):
tickets: sign with the hash from the datacenter configuration
src/PVE/AccessControl.pm | 23 +++++-
src/test/Makefile | 1 +
src/test/ticket-signature-hash-test.pl | 100 +++++++++++++++++++++++++
3 files changed, 122 insertions(+), 2 deletions(-)
create mode 100644 src/test/ticket-signature-hash-test.pl
base-commit: bbc4ed63427249f98c86efd64054dabcca77bd9d
next reply other threads:[~2026-11-13 3:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 3:06 Mark Atwood [this message]
2026-11-13 3:06 ` [PATCH access-control v2 1/1] tickets: sign with the hash from the datacenter configuration Mark Atwood
2026-11-17 16:05 ` Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113030652.3550-1-mark@wolfssl.com \
--to=mark@wolfssl.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox