public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-perl-rs v7 02/21] pve-rs: sdn: add bindings for the eBPF DHCP responder
Date: Thu, 12 Nov 2026 13:41:42 +0100	[thread overview]
Message-ID: <20261112124201.2844423-3-h.laimer@proxmox.com> (raw)
In-Reply-To: <20261112124201.2844423-1-h.laimer@proxmox.com>

The responder answers from records the Perl side builds. They have to
be built under the responder's lock. Otherwise a full pass could
overwrite a newer record with one it built earlier.

So the lock is an object, and every call that takes records is a
method of it. Records cannot be passed in without holding the lock.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 pve-rs/Cargo.toml               |   2 +
 pve-rs/Makefile                 |   3 +
 pve-rs/debian/control           |   1 +
 pve-rs/src/bindings/sdn/dhcp.rs | 200 ++++++++++++++++++++++++++++++++
 pve-rs/src/bindings/sdn/mod.rs  |   1 +
 5 files changed, 207 insertions(+)
 create mode 100644 pve-rs/src/bindings/sdn/dhcp.rs

diff --git a/pve-rs/Cargo.toml b/pve-rs/Cargo.toml
index f22e3aee5674..66769865d9e6 100644
--- a/pve-rs/Cargo.toml
+++ b/pve-rs/Cargo.toml
@@ -45,6 +45,7 @@ proxmox-openid = "1.0.2"
 proxmox-resource-scheduling = "2"
 proxmox-schema = "5"
 proxmox-section-config = "3"
+proxmox-sdn-dhcp = "0.1"
 proxmox-sdn-types = "0.2.5"
 proxmox-shared-cache = "1"
 proxmox-subscription = "1.0.2"
@@ -71,6 +72,7 @@ proxmox-wireguard = { version = "0.1.2" }
 # proxmox-config-digest = { path = "../../proxmox/proxmox-config-digest" }
 # proxmox-daemon = { path = "../../proxmox/proxmox-daemon" }
 # proxmox-dns-api = { path = "../../proxmox/proxmox-dns-api" }
+# proxmox-ebpf = { path = "../../proxmox/proxmox-ebpf" }
 # proxmox-http-error = { path = "../../proxmox/proxmox-http-error" }
 # proxmox-http = { path = "../../proxmox/proxmox-http" }
 # proxmox-human-byte = { path = "../../proxmox/proxmox-human-byte" }
diff --git a/pve-rs/Makefile b/pve-rs/Makefile
index 60f68c7a21be..c597401f789b 100644
--- a/pve-rs/Makefile
+++ b/pve-rs/Makefile
@@ -33,6 +33,9 @@ PERLMOD_PACKAGES := \
 	  PVE::RS::OpenId \
 	  PVE::RS::ResourceScheduling::Static \
 	  PVE::RS::ResourceScheduling::Dynamic \
+	  PVE::RS::SDN::Dhcp \
+	  PVE::RS::SDN::Dhcp::ExclusiveLock \
+	  PVE::RS::SDN::Dhcp::SharedLock \
 	  PVE::RS::SDN::Fabrics \
 	  PVE::RS::SDN::PrefixLists \
 	  PVE::RS::SDN::RouteMaps \
diff --git a/pve-rs/debian/control b/pve-rs/debian/control
index 25b7be8b26e6..fca271543db1 100644
--- a/pve-rs/debian/control
+++ b/pve-rs/debian/control
@@ -33,6 +33,7 @@ Build-Depends: debhelper-compat (= 13),
                librust-proxmox-oci-0.2+default-dev (>= 0.2.2-~~),
                librust-proxmox-openid-1+default-dev (>= 1.0.2-~~),
                librust-proxmox-resource-scheduling-2+default-dev (>= 2.0.0-~~),
+               librust-proxmox-sdn-dhcp-0.1+default-dev,
                librust-proxmox-sdn-types-0.2+default-dev (>= 0.2.5-~~),
                librust-proxmox-section-config-3+default-dev,
                librust-proxmox-shared-cache-1+default-dev,
diff --git a/pve-rs/src/bindings/sdn/dhcp.rs b/pve-rs/src/bindings/sdn/dhcp.rs
new file mode 100644
index 000000000000..09af79486c88
--- /dev/null
+++ b/pve-rs/src/bindings/sdn/dhcp.rs
@@ -0,0 +1,200 @@
+#[perlmod::package(name = "PVE::RS::SDN::Dhcp", lib = "pve_rs")]
+pub mod pve_rs_sdn_dhcp {
+    //! The `PVE::RS::SDN::Dhcp` package.
+    //!
+    //! Bindings for the per-tap eBPF DHCP responder. Interfaces and the records they answer with
+    //! are handed in here and served directly from the kernel. The calls that change the responder
+    //! are methods of a lock object, so nothing writes to it without holding the lock in the mode
+    //! the change needs.
+
+    use std::net::Ipv4Addr;
+
+    use anyhow::Error;
+    use serde::Deserialize;
+
+    use proxmox_network_types::mac_address::MacAddress;
+    use proxmox_sdn_dhcp::{Iface, Record};
+
+    /// One interface's DHCP answer, the address and every option the reply carries.
+    #[derive(Deserialize)]
+    pub struct PerlRecord {
+        ip: Ipv4Addr,
+        prefixlen: u8,
+        server_id: Ipv4Addr,
+        lease: u32,
+        #[serde(default)]
+        router: Option<Ipv4Addr>,
+        #[serde(default)]
+        dns: Option<Ipv4Addr>,
+        #[serde(default)]
+        mtu: Option<u16>,
+    }
+
+    /// One guest interface to serve, with its MAC and the record it answers with.
+    #[derive(Deserialize)]
+    pub struct PerlIface {
+        name: String,
+        #[serde(default)]
+        mac: Option<MacAddress>,
+        #[serde(default)]
+        record: Option<PerlRecord>,
+    }
+
+    impl From<PerlRecord> for Record {
+        fn from(r: PerlRecord) -> Self {
+            Record {
+                ip: r.ip,
+                prefixlen: r.prefixlen,
+                server_id: r.server_id,
+                lease: r.lease,
+                router: r.router,
+                dns: r.dns,
+                mtu: r.mtu,
+            }
+        }
+    }
+
+    impl From<PerlIface> for Iface {
+        fn from(i: PerlIface) -> Self {
+            Iface {
+                name: i.name,
+                mac: i.mac.map(|mac| mac.octets()),
+                record: i.record.map(Record::from),
+            }
+        }
+    }
+
+    pub(super) fn to_ifaces(ifaces: Vec<PerlIface>) -> Vec<Iface> {
+        ifaces.into_iter().map(Iface::from).collect()
+    }
+
+    /// A tap unplug. The interface is gone or going and takes its record with it.
+    #[export]
+    pub fn detach(iface: &str) -> Result<(), Error> {
+        proxmox_sdn_dhcp::detach(iface)
+    }
+}
+
+#[perlmod::package(name = "PVE::RS::SDN::Dhcp::SharedLock", lib = "pve_rs")]
+pub mod pve_rs_sdn_dhcp_shared_lock {
+    //! The `PVE::RS::SDN::Dhcp::SharedLock` package.
+    //!
+    //! The responder's lock taken shared, what a tap plug and a guest's own record change hold.
+    //! Released when the object goes away.
+
+    use anyhow::Error;
+    use perlmod::Value;
+
+    use proxmox_network_types::mac_address::MacAddress;
+    use proxmox_sdn_dhcp::{Iface, Outcome, Record, SharedLock};
+
+    use super::pve_rs_sdn_dhcp::{PerlIface, PerlRecord, to_ifaces};
+
+    /// The lock as Perl holds it.
+    pub struct PerlSharedLock {
+        lock: SharedLock,
+    }
+
+    perlmod::declare_magic!(Box<PerlSharedLock> : &PerlSharedLock as "PVE::RS::SDN::Dhcp::SharedLock");
+
+    /// Class method: take the lock. Plugs hold it next to each other and wait only behind a full
+    /// pass or a record change.
+    #[export]
+    pub fn new(#[raw] class: Value) -> Result<Value, Error> {
+        let lock = proxmox_sdn_dhcp::lock_shared()?;
+        Ok(perlmod::instantiate_magic!(&class, MAGIC => Box::new(PerlSharedLock { lock })))
+    }
+
+    /// Method: a tap plug with the NIC's MAC and the record it answers. Without a record the
+    /// interface gets a link and no entry. Returns false when nothing is loaded yet. An interface
+    /// gone already counts as done.
+    #[export]
+    pub fn attach(
+        #[try_from_ref] this: &PerlSharedLock,
+        iface: String,
+        mac: Option<MacAddress>,
+        record: Option<PerlRecord>,
+    ) -> Result<bool, Error> {
+        let iface = Iface {
+            name: iface,
+            mac: mac.map(|mac| mac.octets()),
+            record: record.map(Record::from),
+        };
+        Ok(this.lock.attach(&iface)? == Outcome::Done)
+    }
+
+    /// Method: a plug onto a bridge the responder does not serve. The interface loses its link and
+    /// its entry.
+    #[export]
+    pub fn detach(#[try_from_ref] this: &PerlSharedLock, iface: &str) -> Result<(), Error> {
+        this.lock.detach(iface)
+    }
+
+    /// Method: a record change for the listed interfaces by a caller holding the guest lock.
+    /// Returns false when nothing is loaded to write into, so a full pass is due.
+    #[export]
+    pub fn update(
+        #[try_from_ref] this: &PerlSharedLock,
+        ifaces: Vec<PerlIface>,
+    ) -> Result<bool, Error> {
+        Ok(this.lock.update(&to_ifaces(ifaces))? == Outcome::Done)
+    }
+}
+
+#[perlmod::package(name = "PVE::RS::SDN::Dhcp::ExclusiveLock", lib = "pve_rs")]
+pub mod pve_rs_sdn_dhcp_exclusive_lock {
+    //! The `PVE::RS::SDN::Dhcp::ExclusiveLock` package.
+    //!
+    //! The responder's lock taken exclusively, what a full pass and a record change hold. Released
+    //! when the object goes away.
+
+    use std::sync::Mutex;
+
+    use anyhow::Error;
+    use perlmod::Value;
+
+    use proxmox_sdn_dhcp::{ExclusiveLock, Outcome};
+
+    use super::pve_rs_sdn_dhcp::{PerlIface, to_ifaces};
+
+    /// The lock as Perl holds it. A full pass and a clear take it mutably, and Perl hands out
+    /// shared references only.
+    pub struct PerlExclusiveLock {
+        lock: Mutex<ExclusiveLock>,
+    }
+
+    perlmod::declare_magic!(Box<PerlExclusiveLock> : &PerlExclusiveLock as "PVE::RS::SDN::Dhcp::ExclusiveLock");
+
+    /// Class method: take the lock, waiting out every plug in flight.
+    #[export]
+    pub fn new(#[raw] class: Value) -> Result<Value, Error> {
+        let lock = Mutex::new(proxmox_sdn_dhcp::lock_exclusive()?);
+        Ok(perlmod::instantiate_magic!(&class, MAGIC => Box::new(PerlExclusiveLock { lock })))
+    }
+
+    /// Method: the full pass over the guest interfaces to serve. Those found here get a link, and
+    /// an entry where they have a record. Every other link and entry goes.
+    #[export]
+    pub fn apply(
+        #[try_from_ref] this: &PerlExclusiveLock,
+        ifaces: Vec<PerlIface>,
+    ) -> Result<(), Error> {
+        this.lock.lock().unwrap().apply(&to_ifaces(ifaces))
+    }
+
+    /// Method: a record change for the listed interfaces. Those not found here are skipped.
+    /// Returns false when nothing is loaded to write into, so a full pass is due.
+    #[export]
+    pub fn update(
+        #[try_from_ref] this: &PerlExclusiveLock,
+        ifaces: Vec<PerlIface>,
+    ) -> Result<bool, Error> {
+        Ok(this.lock.lock().unwrap().update(&to_ifaces(ifaces))? == Outcome::Done)
+    }
+
+    /// Method: detach the responder everywhere and drop its pinned state.
+    #[export]
+    pub fn clear(#[try_from_ref] this: &PerlExclusiveLock) -> Result<(), Error> {
+        this.lock.lock().unwrap().clear()
+    }
+}
diff --git a/pve-rs/src/bindings/sdn/mod.rs b/pve-rs/src/bindings/sdn/mod.rs
index dcae046a7e46..4b99b8fa10e5 100644
--- a/pve-rs/src/bindings/sdn/mod.rs
+++ b/pve-rs/src/bindings/sdn/mod.rs
@@ -1,3 +1,4 @@
+pub(crate) mod dhcp;
 pub(crate) mod fabrics;
 pub(crate) mod prefix_lists;
 pub(crate) mod route_maps;
-- 
2.47.3





  parent reply	other threads:[~2026-11-12 12:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 12:41 [PATCH container/docs/manager/network/proxmox{,-perl-rs,-ve-rs}/qemu-server v7 00/21] sdn: implement DHCP for all zones using eBPF Hannes Laimer
2026-11-12 12:41 ` [PATCH proxmox v7 01/21] network-types: mac address: add an accessor for the bytes Hannes Laimer
2026-11-12 12:41 ` Hannes Laimer [this message]
2026-11-12 12:41 ` [PATCH proxmox-perl-rs v7 03/21] pve-rs: fire the pve-ebpf-update trigger on upgrade Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-network v7 04/21] sdn: zones: take the VXLAN and EVPN MTU from the underlay interface Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-network v7 05/21] sdn: zones: account for IPv6 in the VXLAN and EVPN MTU Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-network v7 06/21] sdn: dhcp: make the lease time configurable per subnet Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-network v7 07/21] sdn: dhcp: require a backend only if a zone on this node uses it Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-network v7 08/21] bpf: add the build, the package and a native harness for BPF programs Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-network v7 09/21] sdn: dhcp: add the per-tap DHCPv4 responder program Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-network v7 10/21] sdn: dhcp: add an eBPF backend answering on each guest interface Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-network v7 11/21] sdn: zones: report interface plugs and unplugs to the DHCP backends Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-network v7 12/21] sdn: zones: factor out the underlay lookup of VXLAN and EVPN zones Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-network v7 13/21] sdn: zones: allow the ebpf DHCP backend on every zone type Hannes Laimer
2026-11-12 12:41 ` [PATCH qemu-server v7 14/21] network: sdn: keep the DHCP backends current on guest NICs Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-container v7 15/21] net: report NIC plugs and removals to the SDN DHCP backends Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-manager v7 16/21] ui: sdn: add zone DHCP backend selector and subnet DHCP options Hannes Laimer
2026-11-12 12:41 ` [PATCH pve-manager v7 17/21] sdn: bring up the DHCP backends at boot before the guests start Hannes Laimer
2026-11-12 12:41 ` [PATCH proxmox-ve-rs v7 18/21] ve-config: sdn: add the ebpf dhcp backend Hannes Laimer
2026-11-12 12:41 ` [PATCH proxmox-ve-rs v7 19/21] sdn-dhcp: add the crate that runs the eBPF DHCP responder Hannes Laimer
2026-11-12 12:42 ` [PATCH pve-docs v7 20/21] sdn: zones: document the MTU taken from the underlay interface Hannes Laimer
2026-11-12 12:42 ` [PATCH pve-docs v7 21/21] sdn: dhcp: add eBPF backend section Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112124201.2844423-3-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal