[PATCH installer v5 23/23] tui: network: list bond member candidates sharing a MAC address once

[Christoph Heiss <c.heiss@proxmox.com>]

Bond members are identified by their MAC address, so physical links
sharing one, for example on hardware that does not assign each port a
unique address, cannot be told apart in the bond configuration anyway.
Listing each of them only results in entries that toggle the same
member, which then also ends up twice in the member list if both are
checked.

Only list the first of these links. When refreshing the labels after
the pinned names changed, only consider physical links, as virtual ones
like bridges or bonds can share the MAC address of a physical link and
would show up with their name instead.

Originally-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Changes v4 -> v5:
  * no changes

Changes v3 -> v4:
  * no changes

Changes v2 -> v3:
  * new patch

 proxmox-tui-installer/src/views/network.rs | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/proxmox-tui-installer/src/views/network.rs b/proxmox-tui-installer/src/views/network.rs
index 4a5d334..80e9d26 100644
--- a/proxmox-tui-installer/src/views/network.rs
+++ b/proxmox-tui-installer/src/views/network.rs
@@ -8,7 +8,7 @@ use cursive::{
     },
 };
 use std::{
-    collections::{BTreeMap, HashMap},
+    collections::{BTreeMap, HashMap, HashSet},
     net::IpAddr,
     sync::{Arc, Mutex},
 };
@@ -642,10 +642,12 @@ impl BondOptionsView {
             .child(DummyView::new());
 
         let mut checkboxes = CheckboxGroup::<MacAddress>::new();
+        // members are identified by MAC address, so links sharing one cannot be told apart
+        let mut listed_macs = HashSet::new();
         for iface in options
             .interfaces
             .iter()
-            .filter(|iface| iface.pinned_id.is_some())
+            .filter(|iface| iface.pinned_id.is_some() && listed_macs.insert(iface.mac))
         {
             let label = Self::format_interface_label(options, iface);
             let is_member = options.bond_options.members.contains(&iface.mac);
@@ -709,7 +711,11 @@ impl BondOptionsView {
             |group: &mut CheckboxGroup<MacAddress>| {
                 let options = options_ref.lock().expect("unpoisoned lock");
                 group.update_labels(&|_, label, mac| {
-                    if let Some(iface) = options.interfaces.iter().find(|iface| iface.mac == *mac) {
+                    if let Some(iface) = options
+                        .interfaces
+                        .iter()
+                        .find(|iface| iface.pinned_id.is_some() && iface.mac == *mac)
+                    {
                         label.set_content(Self::format_interface_label(&options, iface));
                     }
                 });
-- 
2.56.0