public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Nicolas Frey <n.frey@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager 1/3] ui: bulk action window: allow restricting the guest list by VMIDs
Date: Tue, 27 Oct 2026 15:30:48 +0100	[thread overview]
Message-ID: <20261027143050.493707-2-n.frey@proxmox.com> (raw)
In-Reply-To: <20261027143050.493707-1-n.frey@proxmox.com>

in preparation for making guests selectable in the resource tree

Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
 www/manager6/window/BulkAction.js | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/BulkAction.js
index 2e3066a3..c1fc3474 100644
--- a/www/manager6/window/BulkAction.js
+++ b/www/manager6/window/BulkAction.js
@@ -17,6 +17,9 @@ Ext.define('PVE.window.BulkAction', {
     // necessary for the cluster-wide api call
     vmsAsArray: false,
 
+    // if set, only the guests with these VMIDs are offered for selection
+    vmids: undefined,
+
     submit: function (params) {
         let me = this;
 
@@ -310,8 +313,16 @@ Ext.define('PVE.window.BulkAction', {
                     !includeTags.length || tags.some((tag) => includeTags.indexOf(tag) !== -1);
                 let excludeFilter =
                     !excludeTags.length || tags.every((tag) => excludeTags.indexOf(tag) === -1);
-
-                return name && arrayFilters && singleFilters && includeFilter && excludeFilter;
+                let vmidFilter = !me.vmids || me.vmids.includes(value.data.vmid);
+
+                return (
+                    name &&
+                    arrayFilters &&
+                    singleFilters &&
+                    includeFilter &&
+                    excludeFilter &&
+                    vmidFilter
+                );
             };
             let vmselector = me.down('#vms');
             vmselector.getStore().setFilters({
-- 
2.47.3




  reply	other threads:[~2026-10-27 14:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 14:30 [RFC manager 0/3] add bulk actions cmdmenu with multi select in resource tree Nicolas Frey
2026-10-27 14:30 ` Nicolas Frey [this message]
2026-10-27 14:30 ` [PATCH pve-manager 2/3] ui: bulk actions: add cmdmenu with guest selection Nicolas Frey
2026-10-27 14:30 ` [PATCH pve-manager 3/3] ui: resource tree: allow selecting multiple guests for bulk actions Nicolas Frey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261027143050.493707-2-n.frey@proxmox.com \
    --to=n.frey@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal