From: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Subject: [PATCH manager v6 2/4] ui: add cluster level ui settings
Date: Tue, 20 Oct 2026 13:23:18 +0200 [thread overview]
Message-ID: <20261020112321.249890-3-t.ellmenreich@proxmox.com> (raw)
In-Reply-To: <20261020112321.249890-1-t.ellmenreich@proxmox.com>
Extend the cluster settings editor to include editing for the
ui-settings format string. This commit does not contain any actual
ui-setting's yet, the window-title will be added in the next commit.
Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
---
www/manager6/dc/OptionView.js | 47 +++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index dc12aa7e..4fc18ae7 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -91,6 +91,53 @@ Ext.define('PVE.dc.OptionView', {
defaultValue: '__default__',
deleteEmpty: true,
});
+ me.rows['ui-settings'] = {
+ required: true,
+ renderer: (value) => {
+ if (value === undefined) {
+ return gettext('No Overrides');
+ }
+ return '';
+ },
+ header: gettext('UI Settings'),
+ editor: {
+ xtype: 'proxmoxWindowEdit',
+ width: 800,
+ subject: gettext('UI Settings'),
+ fieldDefaults: {
+ labelWidth: 100,
+ },
+ url: '/api2/extjs/cluster/options',
+ items: [
+ {
+ xtype: 'inputpanel',
+ setValues: function (values) {
+ if (values === undefined) {
+ return undefined;
+ }
+ values = values?.['ui-settings'] ?? {};
+ return Proxmox.panel.InputPanel.prototype.setValues.call(this, values);
+ },
+ onGetValues: function (values) {
+ let style = {};
+ if (values.title) {
+ style.title = values.title;
+ }
+ let value = PVE.Parser.printPropertyString(style);
+ if (value === '') {
+ return {
+ delete: 'ui-settings',
+ };
+ }
+ return {
+ 'ui-settings': value,
+ };
+ },
+ items: [],
+ },
+ ],
+ },
+ };
me.add_text_row('email_from', gettext('Email from address'), {
deleteEmpty: true,
vtype: 'proxmoxMail',
--
2.47.3
next prev parent reply other threads:[~2026-10-20 11:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 11:23 [PATCH cluster/manager/yew-mobile-gui v6 0/4] Configurable window titles for nodes Thomas Ellmenreich
2026-10-20 11:23 ` [PATCH cluster v6 1/4] datacenter config: add ui settings Thomas Ellmenreich
2026-10-20 11:23 ` Thomas Ellmenreich [this message]
2026-10-20 11:23 ` [PATCH manager v6 3/4] fix #5475: ui: enable configurable window title Thomas Ellmenreich
2026-10-20 11:23 ` [PATCH pve-yew-mobile-gui v6 4/4] fix #5475: template: use new window-title in index template Thomas Ellmenreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020112321.249890-3-t.ellmenreich@proxmox.com \
--to=t.ellmenreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox