[PATCH ha-manager v5 12/28] resources: add migrate_json_properties() method

[Fiona Ebner <f.ebner@proxmox.com>]

Will be used by the API schema for resource-type specific migration
options. When migrating dependent resources, the migration options
will be filtered according to the resource type, so the property
schema is also needed there.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Dependency bump for pve-container and qemu-server needed!

Changes in v5:
* Add required include for PVE::Cluster already in this patch.
* Only construct properties hash once.

 src/PVE/HA/Resources.pm       | 21 +++++++++++++++++++++
 src/PVE/HA/Resources/PVECT.pm | 17 +++++++++++++++++
 src/PVE/HA/Resources/PVEVM.pm | 17 +++++++++++++++++
 src/PVE/HA/Sim/Resources.pm   |  6 ++++++
 4 files changed, 61 insertions(+)

diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm
index 656cb19..ad603dc 100644
--- a/src/PVE/HA/Resources.pm
+++ b/src/PVE/HA/Resources.pm
@@ -3,6 +3,7 @@ package PVE::HA::Resources;
 use strict;
 use warnings;
 
+use PVE::Cluster;
 use PVE::JSONSchema qw(get_standard_option);
 use PVE::SectionConfig;
 use PVE::HA::Tools;
@@ -103,6 +104,20 @@ EODESC
     },
 };
 
+our $common_migrate_json_properties = {
+    sid => get_standard_option(
+        'pve-ha-resource-or-vm-id',
+        { completion => \&PVE::HA::Tools::complete_sid },
+    ),
+    node => get_standard_option(
+        'pve-node',
+        {
+            completion => \&PVE::Cluster::complete_migration_target,
+            description => "Target node.",
+        },
+    ),
+};
+
 sub verify_name {
     my ($class, $name) = @_;
 
@@ -159,6 +174,12 @@ sub migrate {
     die "implement in subclass";
 }
 
+sub migrate_json_properties {
+    my ($class) = @_;
+
+    die "implement in subclass";
+}
+
 sub config_file {
     my ($class, $id, $nodename) = @_;
 
diff --git a/src/PVE/HA/Resources/PVECT.pm b/src/PVE/HA/Resources/PVECT.pm
index a8fe42e..de7c5b8 100644
--- a/src/PVE/HA/Resources/PVECT.pm
+++ b/src/PVE/HA/Resources/PVECT.pm
@@ -22,6 +22,17 @@ BEGIN {
 
 use base qw(PVE::HA::Resources);
 
+my $ct_migrate_json_properties;
+# FIXME: the extra properties are missing from the docs, since the PVE::API2::LXC module can't be
+# included in the generating docs environment, because of cyclic dependencies..
+my sub init_migrate_json_properties {
+    my $combined = { $PVE::HA::Resources::common_migrate_json_properties->%* };
+    my $extra_migrate_props = eval { PVE::API2::LXC::ha_migrate_json_properties() } // {};
+    die $@ if $@ && !$ENV{PVE_GENERATING_DOCS};
+    $combined->{$_} = $extra_migrate_props->{$_} for keys $extra_migrate_props->%*;
+    $ct_migrate_json_properties = $combined;
+}
+
 sub type {
     return 'ct';
 }
@@ -174,4 +185,10 @@ sub get_static_stats_from_config {
     };
 }
 
+sub migrate_json_properties {
+    my ($class) = @_;
+    init_migrate_json_properties() if !defined($ct_migrate_json_properties);
+    return $ct_migrate_json_properties
+}
+
 1;
diff --git a/src/PVE/HA/Resources/PVEVM.pm b/src/PVE/HA/Resources/PVEVM.pm
index 3b61113..914f406 100644
--- a/src/PVE/HA/Resources/PVEVM.pm
+++ b/src/PVE/HA/Resources/PVEVM.pm
@@ -22,6 +22,17 @@ BEGIN {
 
 use base qw(PVE::HA::Resources);
 
+my $vm_migrate_json_properties;
+# FIXME: the extra properties are missing from the docs, since the PVE::API2::QEMU module can't be
+# included in the generating docs environment, because of cyclic dependencies..
+my sub init_migrate_json_properties {
+    my $combined = { $PVE::HA::Resources::common_migrate_json_properties->%* };
+    my $extra_migrate_props = eval { PVE::API2::Qemu::ha_migrate_json_properties() } // {};
+    die $@ if $@ && !$ENV{PVE_GENERATING_DOCS};
+    $combined->{$_} = $extra_migrate_props->{$_} for keys $extra_migrate_props->%*;
+    $vm_migrate_json_properties = $combined;
+}
+
 sub type {
     return 'vm';
 }
@@ -194,4 +205,10 @@ sub get_static_stats_from_config {
     };
 }
 
+sub migrate_json_properties {
+    my ($class) = @_;
+    init_migrate_json_properties() if !defined($vm_migrate_json_properties);
+    return $vm_migrate_json_properties;
+}
+
 1;
diff --git a/src/PVE/HA/Sim/Resources.pm b/src/PVE/HA/Sim/Resources.pm
index a464c62..730bfaa 100644
--- a/src/PVE/HA/Sim/Resources.pm
+++ b/src/PVE/HA/Sim/Resources.pm
@@ -122,6 +122,12 @@ sub migrate {
     return defined($ss->{$sid}) ? 0 : 1;
 }
 
+sub migrate_json_properties {
+    my ($class) = @_;
+
+    return $PVE::HA::Resources::common_migrate_json_properties;
+}
+
 sub remove_locks {
     my ($self, $haenv, $id, $locks, $service_node) = @_;
 
-- 
2.47.3