public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH common 2/2] section config: register: add note about potential ha-manager breakage
Date: Mon, 19 Oct 2026 15:36:22 +0200	[thread overview]
Message-ID: <20261019133754.177328-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20261019133754.177328-1-f.ebner@proxmox.com>

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/SectionConfig.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/PVE/SectionConfig.pm b/src/PVE/SectionConfig.pm
index 2edf5ae..66375ac 100644
--- a/src/PVE/SectionConfig.pm
+++ b/src/PVE/SectionConfig.pm
@@ -263,6 +263,9 @@ For example:
 
 =cut
 
+# ha-manager without commit "rules: fix call to parent classes register() method" accidentally
+# passed a second argument, so needs a versioned Breaks before enforcing callers to use a single
+# argument or adding a second argument to the method.
 sub register {
     my ($class) = @_;
 
-- 
2.47.3





  parent reply	other threads:[~2026-10-19 13:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 13:36 [PATCH-SERIES ha-manager/common 0/2] rules: fix call to parent class' register() method Fiona Ebner
2026-10-19 13:36 ` [PATCH ha-manager 1/2] rules: fix call to parent classes " Fiona Ebner
2026-10-19 13:36 ` Fiona Ebner [this message]
2026-10-19 20:31 ` applied: [PATCH-SERIES ha-manager/common 0/2] rules: fix call to parent class' " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261019133754.177328-3-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal