public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Michael Ryom <Michael@RyomHerold.dk>
To: pve-devel@lists.proxmox.com, Daniel Kral <d.kral@proxmox.com>
Cc: Michael Ryom <Michael@RyomHerold.dk>
Subject: Re: [PATCH ha-manager 7/7] manager: auto rebalance: only balance under actual node resource pressure
Date: Sun, 18 Oct 2026 14:48:32 +0200	[thread overview]
Message-ID: <20261018124832.24605-1-Michael@RyomHerold.dk> (raw)
In-Reply-To: <DM4MS6K4YBQ0.KZYBEBC8E4IZ@proxmox.com>

Hi Daniel,

thanks for the detailed explanation - I agree with your points and
have dropped this patch from v2.

In particular, that a node-local PSI value can say "something is
wrong here" but not what should go where, is what I ran into myself
when trying to couple the candidate selection to the pressure: without
a model of what each guest needs and gets, the gate only decides
*when* to run a balancer that still optimizes for an even load.

For what it's worth, the measurements from the test cluster pointed in
the same direction: over 23 hours, the gate opened 45 times, but only 5
of these openings were backed by a one-minute average above the
threshold - the avg10 value sampled once per round mostly caught short
spikes, so a gate would have needed a sustain requirement on top.

I'll come back with a separate proposal (RFC) for the "what and where"
part, based on per-guest measurements (CPU time a guest wanted but did
not get, from the schedstat run_delay of its threads) rather than on
node-local pressure, and with memory treated as a constraint instead
of something to balance. That is independent of this series.

Best regards,
Michael



      reply	other threads:[~2026-10-18 12:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20 16:22 [PATCH ha-manager 0/7] auto rebalance: fix failure retry loop, oscillation and idle-cluster churn Michael Ryom
2026-09-20 16:22 ` [PATCH ha-manager 1/7] fix #8059: manager: auto rebalance: back off failed motions and add per-resource cooldown Michael Ryom
2026-10-14 11:49   ` Daniel Kral
2026-10-18 12:48     ` Michael Ryom
2026-09-20 16:22 ` [PATCH ha-manager 2/7] env: dynamic service stats: use host-side memory footprint of guests Michael Ryom
2026-09-21  9:18   ` Dominik Rusovac
2026-09-20 16:22 ` [PATCH ha-manager 3/7] manager: auto rebalance: require a minimum absolute imbalance improvement Michael Ryom
2026-09-22  6:18   ` Dominik Rusovac
2026-09-22 10:09     ` Michael Ryom
2026-10-14 12:23   ` Daniel Kral
2026-10-14 13:03     ` Dominik Rusovac
2026-10-18 12:48       ` Michael Ryom
2026-09-20 16:22 ` [PATCH ha-manager 4/7] sim: hardware: report actual running state in cluster service stats Michael Ryom
2026-09-20 16:22 ` [PATCH ha-manager 5/7] sim: hardware: allow setting a base load for nodes Michael Ryom
2026-09-20 16:22 ` [PATCH ha-manager 6/7] usage: dynamic: smooth the unaccounted node load Michael Ryom
2026-09-20 16:22 ` [PATCH ha-manager 7/7] manager: auto rebalance: only balance under actual node resource pressure Michael Ryom
2026-10-14 14:29   ` Daniel Kral
2026-10-18 12:48     ` Michael Ryom [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261018124832.24605-1-Michael@RyomHerold.dk \
    --to=michael@ryomherold.dk \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal