public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Kefu Chai <k.chai@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager] ceph-after-pve-cluster: use a prefix drop-in for ceph-* services
Date: Wed, 14 Oct 2026 18:43:21 +0800	[thread overview]
Message-ID: <20261014104321.2652781-1-k.chai@proxmox.com> (raw)

The Ceph services read /etc/ceph/ceph.conf, a symlink into /etc/pve,
so they have to start after pve-cluster. Until now we installed the
drop-in that orders them unit by unit, and missed the units that came
later. So:

1. Replace the drop-ins for ceph-mon@, ceph-mgr@, ceph-osd@, ceph-mds@
   and ceph-volume@ with a single one in ceph-.service.d/. systemd
   applies it to every unit whose name starts with "ceph-", including
   ones Ceph adds later.

2. With that, ceph-crash is ordered after pve-cluster too. Without the
   drop-in it could start before /etc/pve was mounted, and its startup
   check failed with:

     Error initializing cluster client: ObjectNotFound('RADOS object
     not found (error calling conf_read_file)')

   ceph-exporter and ceph-radosgw@ had no drop-in either and are now
   covered the same way.

3. rbdmap.service and cephfs-mirror@.service read the same config, but
   their names don't match the prefix, so install the drop-in for each
   of them.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 services/Makefile | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/services/Makefile b/services/Makefile
index 347a6d11..01e8fc99 100644
--- a/services/Makefile
+++ b/services/Makefile
@@ -21,16 +21,12 @@ SERVICES=			\
 install: $(SERVICES)
 	install -d $(SERVICEDIR)
 	install -m 0644 $(SERVICES) $(SERVICEDIR)
-	install -d $(SERVICEDIR)/ceph-mon@.service.d
-	install -m 0644 ceph-after-pve-cluster.conf $(SERVICEDIR)/ceph-mon@.service.d
-	install -d $(SERVICEDIR)/ceph-mgr@.service.d
-	install -m 0644 ceph-after-pve-cluster.conf $(SERVICEDIR)/ceph-mgr@.service.d
-	install -d $(SERVICEDIR)/ceph-osd@.service.d
-	install -m 0644 ceph-after-pve-cluster.conf $(SERVICEDIR)/ceph-osd@.service.d
-	install -d $(SERVICEDIR)/ceph-volume@.service.d
-	install -m 0644 ceph-after-pve-cluster.conf $(SERVICEDIR)/ceph-volume@.service.d
-	install -d $(SERVICEDIR)/ceph-mds@.service.d
-	install -m 0644 ceph-after-pve-cluster.conf $(SERVICEDIR)/ceph-mds@.service.d
+	install -d $(SERVICEDIR)/ceph-.service.d
+	install -m 0644 ceph-after-pve-cluster.conf $(SERVICEDIR)/ceph-.service.d
+	install -d $(SERVICEDIR)/rbdmap.service.d
+	install -m 0644 ceph-after-pve-cluster.conf $(SERVICEDIR)/rbdmap.service.d
+	install -d $(SERVICEDIR)/cephfs-mirror@.service.d
+	install -m 0644 ceph-after-pve-cluster.conf $(SERVICEDIR)/cephfs-mirror@.service.d
 	install -d $(DESTDIR)/usr/share/doc/$(PACKAGE)/examples/
 
 .PHONY: clean
-- 
2.47.3





                 reply	other threads:[~2026-10-14 10:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261014104321.2652781-1-k.chai@proxmox.com \
    --to=k.chai@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal