public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Davíð Steinn Geirsson" <david@dsg.is>
To: pve-devel@lists.proxmox.com
Cc: "Davíð Steinn Geirsson" <david@dsg.is>
Subject: [PATCH] drive: use the storage daemon for a tpmstate on rbd with krbd disabled
Date: Wed,  7 Oct 2026 14:03:32 +0000	[thread overview]
Message-ID: <20261007140332.1675562-1-david@dsg.is> (raw)

With a Ceph cluster where min-compat-client is too new for krbd, vTPM
fails if its image is stored on rbd with:

  rbd: sysfs write failed
  libceph: RADOS feature set mismatch: server's required > my supported

Fix by using the FUSE path when krbd is disabled for the storage.

Signed-off-by: Davíð Steinn Geirsson <david@dsg.is>
---
 src/PVE/QemuServer/Drive.pm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm
index 0b57371..d6e4b3e 100644
--- a/src/PVE/QemuServer/Drive.pm
+++ b/src/PVE/QemuServer/Drive.pm
@@ -1227,6 +1227,12 @@ sub drive_uses_qsd_fuse {
         my $path = PVE::Storage::path($storecfg, $drive->{file});
         return 1 if $path =~ m!^iscsi://!;
 
+        # The RBD plugin maps a volume with the kernel client, which may not
+        # speak the cluster's feature set; with krbd disabled, reach the
+        # volume through librbd like every other drive.
+        my $scfg = PVE::Storage::storage_config($storecfg, $storeid);
+        return 1 if $scfg->{type} eq 'rbd' && !$scfg->{krbd};
+
         my $format = checked_volume_format($storecfg, $drive->{file});
         return $format ne 'raw';
     }
-- 
2.55.0




                 reply	other threads:[~2026-10-07 14:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261007140332.1675562-1-david@dsg.is \
    --to=david@dsg.is \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal