From: Michal Fox <me@dualfroz.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH storage 0/3] api: disks: zfs: fix error counters and in-use spares in pool details
Date: Sat, 3 Oct 2026 12:49:14 +0000 [thread overview]
Message-ID: <20261003124917.7-1-me@dualfroz.com> (raw)
the ZFS pool details of the disk API showed wrong error counters once
they reach 1024, as 'zpool status' shortens them to a value like
'1.10K' (#6640, #6938), and lost the message of a hot spare in use,
whose words got parsed as counters (#6389). both also logged "isn't
numeric" warnings to the journal.
1/3 adds a test for the zpool status parser, which the two fixes extend
with their case. 2/3 requests exact counters with '-p', as Fabian
suggested in #6938, and 3/3 builds on that by only accepting digits as
counters.
tested with 'make test' in src, each patch on its own, and with the
zpool output from #6389.
Michal Fox (3):
test: add tests for zpool status parsing of the ZFS disk API
fix #6640, #6938: api: disks: zfs: return exact error counters
fix #6389: api: disks: zfs: parse the message of hot spares in use
src/PVE/API2/Disks/ZFS.pm | 4 +-
src/test/run_disk_tests.pl | 2 +-
src/test/zfs_pool_detail_test.pm | 345 +++++++++++++++++++++++++++++++
3 files changed, 348 insertions(+), 3 deletions(-)
create mode 100644 src/test/zfs_pool_detail_test.pm
--
2.43.0
next reply other threads:[~2026-10-03 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 12:49 Michal Fox [this message]
2026-10-03 12:49 ` [PATCH storage 1/3] test: add tests for zpool status parsing of the ZFS disk API Michal Fox
2026-10-03 12:49 ` [PATCH storage 2/3] fix #6640, #6938: api: disks: zfs: return exact error counters Michal Fox
2026-10-03 12:49 ` [PATCH storage 3/3] fix #6389: api: disks: zfs: parse the message of hot spares in use Michal Fox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003124917.7-1-me@dualfroz.com \
--to=me@dualfroz.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox