[PATCH pve-manager v3 12/16] ui: firewall: ipset: add controls to update/delete references on edit

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

Add the shared 'update-references' selector to the update dialog, so a
rename can (force-)update all references to the ipset, and replace the
plain remove button with a confirmation dialog to handle dangling
references following the ipset deletion.

StdRemoveButton cannot pass the extra 'dangling-references' parameter,
so the remove button is switched to a plain button that opens the
shared FirewallObjectRemove dialog.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/panel/IPSet.js | 35 ++++++++++++++++++++++++++++++++---
 1 file changed, 32 insertions(+), 3 deletions(-)

diff --git a/www/manager6/panel/IPSet.js b/www/manager6/panel/IPSet.js
index 9e0203a0..7dc3668f 100644
--- a/www/manager6/panel/IPSet.js
+++ b/www/manager6/panel/IPSet.js
@@ -91,6 +91,16 @@ Ext.define('PVE.IPSetList', {
                         value: rec.data.comment,
                         fieldLabel: gettext('Comment'),
                     },
+                    {
+                        xtype: 'pveFirewallUpdateReferences',
+                        noTip: gettext(
+                            'Do not update referencing rules when renaming this IPSet. Note that this will render any reference to this IPSet invalid.',
+                        ),
+                        yesTip: gettext('Update referencing rules to point to the new IPSet name.'),
+                        forceTip: gettext(
+                            'Update referencing rules to point to the new IPSet name, overwriting any pre-existing IPSet with the target name. Can be used in case a failed rename left the cluster configuration in a partially-updated state.',
+                        ),
+                    },
                 ],
             });
             win.show();
@@ -134,11 +144,30 @@ Ext.define('PVE.IPSetList', {
             },
         });
 
-        me.removeBtn = Ext.create('Proxmox.button.StdRemoveButton', {
+        me.removeBtn = Ext.create('Proxmox.button.Button', {
+            text: gettext('Remove'),
+            disabled: true,
+            dangerous: true,
             enableFn: (rec) => canEdit,
             selModel: sm,
-            baseurl: me.base_url + '/',
-            callback: reload,
+            handler: function (btn, event, rec) {
+                Ext.create('PVE.window.FirewallObjectRemove', {
+                    item: { id: rec.data.name },
+                    url: me.base_url + '/' + rec.data.name,
+                    text: Ext.String.format(
+                        gettext("Are you sure you want to remove IPSet '{0}'?"),
+                        rec.data.name,
+                    ),
+                    keepTip: gettext(
+                        'Keep referencing rules untouched. Some firewall configurations may end up with dangling references, which are dropped from the generated ruleset.',
+                    ),
+                    disableTip: gettext(
+                        'Disable all firewall rules referencing this IPSet, keeping them in the configuration.',
+                    ),
+                    dropTip: gettext('Delete all firewall rules referencing this IPSet.'),
+                    apiCallDone: reload,
+                }).show();
+            },
         });
 
         Ext.apply(me, {
-- 
2.47.3