public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-xtermjs 0/3] xterm.js: fix obstructed start button
Date: Wed,  2 Sep 2026 09:40:36 +0200	[thread overview]
Message-ID: <20260902074338.914500-1-d.csapak@proxmox.com> (raw)

The first two patches are just formatting cleanup to make development
easier when using proxmox-biome as LSP and the third patch is the actual
fix.

Not sure how this was broken, I tested this with old chrome/firefox
versions and our older xterm.js packages and could still reproduce. Then
tested on a PVE 8.4 install and it also happened. (Though with older
xterm.js releases it was not as noticable since the default
background-color changed in the last few releases)

So my current guess is that either something unrelated changed which
has an influence on this (desktop environments, etc.) or this was simply
broken since a long time.

Dominik Csapak (3):
  xterm.js: add tidy make target
  xterm.js: run make tidy
  xterm.js: fix obstructed start button

 xterm.js/Makefile              |   4 +
 xterm.js/src/index.html.hbs.in |   2 +-
 xterm.js/src/index.html.tpl.in |   2 +-
 xterm.js/src/main.js           | 562 ++++++++++++++++++---------------
 xterm.js/src/style.css         | 125 ++++----
 xterm.js/src/util.js           | 158 ++++-----
 6 files changed, 454 insertions(+), 399 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-09-02  7:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  7:40 Dominik Csapak [this message]
2026-09-02  7:40 ` [PATCH pve-xtermjs 1/3] xterm.js: add tidy make target Dominik Csapak
2026-09-02  7:40 ` [PATCH pve-xtermjs 2/3] xterm.js: run make tidy Dominik Csapak
2026-09-02  7:40 ` [PATCH pve-xtermjs 3/3] xterm.js: fix obstructed start button Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902074338.914500-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal