From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-firewall] nftables: build without the config extension
Date: Thu, 27 Aug 2026 13:58:03 +0200 [thread overview]
Message-ID: <20260827115803.1331245-1-h.laimer@proxmox.com> (raw)
The bridge-name import and the anyhow imports were unconditional
although only the config extension uses them, so without that feature
the crate failed to build and warned about unused imports.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
proxmox-nftables/src/expression.rs | 3 ++-
proxmox-nftables/src/statement.rs | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/proxmox-nftables/src/expression.rs b/proxmox-nftables/src/expression.rs
index 0b46cc5..ca7a4e7 100644
--- a/proxmox-nftables/src/expression.rs
+++ b/proxmox-nftables/src/expression.rs
@@ -1,5 +1,4 @@
use crate::types::{ElemConfig, Verdict};
-use proxmox_ve_config::host::types::BridgeName;
use serde::{Deserialize, Serialize};
use std::net::{IpAddr, Ipv4Addr, Ipv6Addr};
@@ -13,6 +12,8 @@ use proxmox_ve_config::firewall::types::port::{PortEntry, PortList};
use proxmox_ve_config::firewall::types::rule_match::{IcmpCode, IcmpType, Icmpv6Code, Icmpv6Type};
#[cfg(feature = "config-ext")]
use proxmox_ve_config::guest::types::Vmid;
+#[cfg(feature = "config-ext")]
+use proxmox_ve_config::host::types::BridgeName;
#[derive(Clone, Debug, Deserialize, Serialize)]
#[serde(rename_all = "lowercase")]
diff --git a/proxmox-nftables/src/statement.rs b/proxmox-nftables/src/statement.rs
index d8899a8..44a4c48 100644
--- a/proxmox-nftables/src/statement.rs
+++ b/proxmox-nftables/src/statement.rs
@@ -1,3 +1,4 @@
+#[cfg(feature = "config-ext")]
use anyhow::{Error, bail};
use serde::{Deserialize, Serialize};
--
2.47.3
reply other threads:[~2026-08-27 11:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827115803.1331245-1-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox