public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox_dart_api_client 1/1] cleanup: avoid print statements
Date: Fri, 21 Aug 2026 15:07:18 +0200	[thread overview]
Message-ID: <20260821130718.330515-4-s.shaji@proxmox.com> (raw)
In-Reply-To: <20260821130718.330515-1-s.shaji@proxmox.com>

Dart linter rules recommend avoiding print statements [0]. To align with
this, remove all print statements. The lints recommended.yaml config [1]
does not have the rule by default so explicitly add it.

- [0] https://dart.dev/tools/linter-rules/avoid_print
- [1] https://github.com/dart-lang/core/blob/main/pkgs/lints/rules.md

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 analysis_options.yaml     | 6 +++---
 lib/src/authenticate.dart | 1 -
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/analysis_options.yaml b/analysis_options.yaml
index bf158d5..d1644c7 100644
--- a/analysis_options.yaml
+++ b/analysis_options.yaml
@@ -5,9 +5,9 @@ include: package:lints/recommended.yaml
 
 # For lint rules and documentation, see http://dart-lang.github.io/linter/lints.
 # Uncomment to specify additional rules.
-# linter:
-#   rules:
-#     - camel_case_types
+linter:
+  rules:
+    - avoid_print
 
 analyzer:
   errors:
diff --git a/lib/src/authenticate.dart b/lib/src/authenticate.dart
index 7bd9cef..e508fd9 100644
--- a/lib/src/authenticate.dart
+++ b/lib/src/authenticate.dart
@@ -36,7 +36,6 @@ Future<ProxmoxApiClient> authenticate(
 
     // for backward compat with older products, e.g. PVE < 7.1, retry without 'new-format'
     if (response.statusCode == 400) {
-      print("retrying for backward compat!");
       final errors = jsonDecode(response.body)['errors'] ?? {};
       if (errors.containsKey('new-format')) {
         var body = {
-- 
2.47.3





      parent reply	other threads:[~2026-08-21 13:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 13:07 [PATCH proxmox{_login_manager,_dart_api_client}/pve_flutter_frontend 0/3] cleanup: enable avoid_print Linter rule Shan Shaji
2026-08-21 13:07 ` [PATCH pve_flutter_frontend 1/1] cleanup: remove print statements Shan Shaji
2026-08-21 13:07 ` [PATCH proxmox_login_manager " Shan Shaji
2026-08-21 13:07 ` Shan Shaji [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260821130718.330515-4-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal