public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-container] lxc: pass hostname correctly when giving up an ip address
Date: Wed, 19 Aug 2026 15:34:59 +0200	[thread overview]
Message-ID: <20260819133459.915481-1-h.laimer@proxmox.com> (raw)

A container has no `name`, only a `hostname`. This led to left behind
DNS records.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 src/PVE/LXC/Config.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 7c81834..41dd22f 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -1850,7 +1850,7 @@ sub vmconfig_apply_pending {
                             PVE::Network::SDN::Vnets::del_ips_from_mac(
                                 $old_net->{bridge},
                                 $old_net->{hwaddr},
-                                $conf->{name},
+                                $conf->{hostname},
                             );
                             PVE::Network::SDN::Vnets::add_next_free_cidr(
                                 $net->{bridge},
-- 
2.47.3





                 reply	other threads:[~2026-08-19 13:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260819133459.915481-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal