[PATCH pve-firewall v2 5/9] api: aliases: add option to GC references on delete

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

Deleting an alias referenced by rules or security groups leaves dangling
references, which the firewall fails to parse and drops.

Add a 'delete-references' option to the delete endpoint to allow
removing such references. For cluster aliases, this also covers all
downstream configs (host, guest and vnet).

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 src/PVE/API2/Firewall/Aliases.pm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/src/PVE/API2/Firewall/Aliases.pm b/src/PVE/API2/Firewall/Aliases.pm
index 657f333..b8ddb53 100644
--- a/src/PVE/API2/Firewall/Aliases.pm
+++ b/src/PVE/API2/Firewall/Aliases.pm
@@ -316,6 +316,12 @@ sub register_delete_alias {
 
     $properties->{name} = $api_properties->{name};
     $properties->{digest} = get_standard_option('pve-config-digest');
+    $properties->{'delete-references'} = {
+        type => 'boolean',
+        optional => 1,
+        description => 'Delete dangling references after deleting the alias.',
+        default => 0,
+    };
 
     $class->register_method({
         name => 'remove_alias',
@@ -345,6 +351,11 @@ sub register_delete_alias {
 
                     my $name = lc($param->{name});
 
+                    if ($param->{'delete-references'}) {
+                        my $spec = get_object_spec('aliases');
+                        update_refs($fw_conf, $spec, $param->{name}, undef, $class->rule_env());
+                    }
+
                     delete $aliases->{$name};
 
                     $class->save_aliases($param, $fw_conf, $aliases);
-- 
2.47.3