From: Elias Huhsovitz <e.huhsovitz@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: [PATCH manager 0/2] fix #7136: ui: tree: harmonize folder view resource ordering
Date: Tue, 18 Aug 2026 10:31:08 +0200 [thread overview]
Message-ID: <20260818083110.15786-1-e.huhsovitz@proxmox.com> (raw)
This patch series fixes bug #7136, where resources in the Folder View
were ordered lexicographically instead of following the order
defined by the `getTypeOrder` function. It also includes a follow-up
cleanup to align variable declarations with modern javascript
standards.
Previously, grouping nodes in the Folder View were assigned the literal
type 'type' instead of their actual resource type, such as 'node' or
'network'. This caused `getTypeOrder` to return a default value for all
groups, resulting in a lexicographical sorting fallback.
Other views, such as Server View, pass the correct types to
`getTypeOrder`.
Patch 1/2 fixes the root cause by setting the grouping node's type to
the actual resource type when grouping by 'type'. This restores the
correct sort order (LXC, QEMU, Node, SDN, Network, Storage) and allows
icon and text resolution via typeDefaults.
Patch 2/2 replaces let with const for variables that are never
reassigned. This aligns the with modern JavaScript best practices.
Elias Huhsovitz (2):
fix #7136: ui: tree: harmonize folder view resource ordering
ui: tree: reduce reduce usage of `let` keyword
www/manager6/tree/ResourceTree.js | 148 ++++++++++++++++--------------
1 file changed, 77 insertions(+), 71 deletions(-)
--
2.47.3
next reply other threads:[~2026-08-18 8:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 8:31 Elias Huhsovitz [this message]
2026-08-18 8:31 ` [PATCH manager 1/2] fix #7136: ui: tree: harmonize folder view resource ordering Elias Huhsovitz
2026-08-18 9:15 ` Dominik Csapak
2026-08-18 9:36 ` Elias Huhsovitz
2026-08-18 8:31 ` [PATCH manager 2/2] ui: tree: reduce reduce usage of `let` keyword Elias Huhsovitz
2026-08-18 9:15 ` Dominik Csapak
2026-08-18 12:09 ` superseded: [PATCH manager 0/2] fix #7136: ui: tree: harmonize folder view resource ordering Elias Huhsovitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260818083110.15786-1-e.huhsovitz@proxmox.com \
--to=e.huhsovitz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox