From: Aaron Carson <aaron@aaroncarson.co.uk>
To: pve-devel@lists.proxmox.com
Cc: aaron@aaroncarson.co.uk
Subject: [PATCH proxmox-acme v2] acme: fix USER_AGENT variable interpolation in curl calls
Date: Wed, 12 Aug 2026 12:02:28 +0000 [thread overview]
Message-ID: <20260812120711.3626458-1-aaron@aaroncarson.co.uk> (raw)
The variable was not interpolated, so ACME requests were sent with
the literal string USER_AGENT as the user agent instead of the
configured value.
Signed-off-by: Aaron Carson <aaron@aaroncarson.co.uk>
---
Hi folks, resending with the correct subject prefix (v1 went out as
[PATCH acme]). Noticed the user agent my DNS server was seeing when
updating records for ACME was literally the string USER_AGENT - the
variable isn't interpolated in the two _get_impl curl calls. My CLA
is on file (office@ responded on 6th Aug).
v2: correcting subject prefix, no code changes
src/proxmox-acme | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/proxmox-acme b/src/proxmox-acme
index 705f7df..39c770b 100644
--- a/src/proxmox-acme
+++ b/src/proxmox-acme
@@ -348,9 +348,9 @@ _get_impl() {
_CURL="$_CURL --connect-timeout $t"
fi
if [ "$onlyheader" ]; then
- $_CURL -I --user-agent "USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url"
+ $_CURL -I --user-agent "$USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url"
else
- $_CURL --user-agent "USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url"
+ $_CURL --user-agent "$USER_AGENT" -H "$_H1" -H "$_H2" -H "$_H3" -H "$_H4" -H "$_H5" "$url"
fi
ret=$?
if [ "$ret" != "0" ]; then
--
2.52.0
reply other threads:[~2026-08-12 12:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812120711.3626458-1-aaron@aaroncarson.co.uk \
--to=aaron@aaroncarson.co.uk \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox