public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: David Riley <d.riley@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH storage 0/2] fix #6050: normalize paths in mount status checks
Date: Fri,  7 Aug 2026 11:36:55 +0200	[thread overview]
Message-ID: <20260807093657.23649-1-d.riley@proxmox.com> (raw)

Manual edits in the `storage.cfg` can introduce trailing or extra
slashes into storage paths. While these storages mount and function
properly, the kernel normalizes entries in `/proc/mounts` by omitting
trailing slashes. 

As a result, status verification checks in the NFS and CIFS/SMB
Storage Plugin fail due to string mismatches, causing working storages
to continuously report as 'inactive' in both the web UI and via
`pvesm status`.

This series sanitizes the export, share, and subdirectory paths prior
to checking `/proc/mounts`, ensuring active mounts are correctly
recognized.


pve-storage:

David Riley (2):
  fix #6050: nfs: strip trailing slashes from mount status check
  fix #6050: cifs: normalize share and subdir paths for mount and status

 src/PVE/Storage/CIFSPlugin.pm | 32 ++++++++++++++++++++++++++++----
 src/PVE/Storage/NFSPlugin.pm  |  6 +++++-
 2 files changed, 33 insertions(+), 5 deletions(-)


Summary over all repositories:
  2 files changed, 33 insertions(+), 5 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-08-07  9:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07  9:36 David Riley [this message]
2026-08-07  9:36 ` [PATCH pve-storage 1/2] fix #6050: nfs: strip trailing slashes from mount status check David Riley
2026-08-07  9:36 ` [PATCH pve-storage 2/2] fix #6050: cifs: normalize share and subdir paths for mount and status David Riley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260807093657.23649-1-d.riley@proxmox.com \
    --to=d.riley@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal