public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager] ui: sdn: dns selector: keep an untouched edit dialog clean
Date: Thu,  6 Aug 2026 18:40:01 +0200	[thread overview]
Message-ID: <20260806164001.1901538-1-h.laimer@proxmox.com> (raw)

The selector starts out on the empty string, and once its store has
loaded an empty selection reads back as null. Both mean that no server
is picked, but the dirty tracking told them apart, so just opening a
zone edit dialog enabled its reset button and let an unchanged form be
submitted.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
just noticed here because zone edit kept being marked as dirty, this
could also make sense in ComboGrid directly (don't think we ever
actually differentiate between `null` and `''`?)

 www/manager6/form/SDNDnsSelector.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/www/manager6/form/SDNDnsSelector.js b/www/manager6/form/SDNDnsSelector.js
index 7a134541..9d36e8d7 100644
--- a/www/manager6/form/SDNDnsSelector.js
+++ b/www/manager6/form/SDNDnsSelector.js
@@ -8,6 +8,10 @@ Ext.define(
         valueField: 'dns',
         displayField: 'dns',
 
+        isEqual: function (value1, value2) {
+            return String(value1 ?? '') === String(value2 ?? '');
+        },
+
         initComponent: function () {
             var me = this;
 
-- 
2.47.3





                 reply	other threads:[~2026-08-06 16:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260806164001.1901538-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal