public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Elias Huhsovitz <e.huhsovitz@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: [PATCH storage] fix: #7844: diskmanage: whitelist GRAID virtual block devices.
Date: Thu,  6 Aug 2026 12:56:32 +0200	[thread overview]
Message-ID: <20260806105632.91936-1-e.huhsovitz@proxmox.com> (raw)

Graid virtual drives are of format `gdgXnY`. This format is currently
not whitelisted, resulting in the `Diskmanage::get_disks` subroutine to
ignore the devices.

Add regex to inlcude graid devices of format `gdgXnY`.

Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
---
Graid is propietary software. I current do not have access to any kind of
authentic graid software or device. I tested this patch by creating a mock
block device (e.g. gdg0n1) using a small kernel module.

If there is a more robust version to test changes like this, please let me
know.

 src/PVE/Diskmanage.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/PVE/Diskmanage.pm b/src/PVE/Diskmanage.pm
index d9ce0d0..f3a34dc 100644
--- a/src/PVE/Diskmanage.pm
+++ b/src/PVE/Diskmanage.pm
@@ -562,10 +562,12 @@ sub get_disks {
             # - xvdX:       xen virtual block device
             # - nvmeXnY:    nvme devices
             # - cciss!cXnY  cciss devices
+            # - gdgXnY:     graid devices
             return
                 if $dev !~ m/^(h|s|x?v)d[a-z]+$/
                 && $dev !~ m/^nvme\d+n\d+$/
-                && $dev !~ m/^cciss\!c\d+d\d+$/;
+                && $dev !~ m/^cciss\!c\d+d\d+$/
+                && $dev !~ m/^gdg\d+n\d+$/;
 
             my $data = get_udev_info("/sys/block/$dev") // return;
             my $devpath = $data->{devpath};
-- 
2.47.3





                 reply	other threads:[~2026-08-06 10:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260806105632.91936-1-e.huhsovitz@proxmox.com \
    --to=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal