public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Jakob Klocker <j.klocker@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Jakob Klocker <j.klocker@proxmox.com>
Subject: [PATCH storage v2 0/2] fix #7598: qemu-img: increase timeout for image resize
Date: Tue,  4 Aug 2026 11:04:36 +0200	[thread overview]
Message-ID: <20260804090438.58491-1-j.klocker@proxmox.com> (raw)

Image resizing currently has a timeout of 10 seconds, which can fail
on slow disks and leave the VM in a state where the disk is updated,
but the VM config isn't. 

Since there is no deterministic way to check, with less overhead, if
this is the case, increasing the timeout is the most pragmatic
solution. The resize is only called in a worker context anyway,
therefore this patch series mirrors the ZFS timeout: it increases
the timeout in a worker context to 1 hour; as a fallback for a 
non-worker context the timeout stays 10 seconds.

Additionally there was a minor refactoring: the timeout parameter for
qemu_img_resize was dropped, since the timeout can't be set through
the PVE API and was always hardcoded to 10 seconds.

Changes since v2
-----------------

- drop the timeout parameter in qemu_img_resize
- increase the timeout instead of querying the disk information
(see v1 for more info. Thanks @Fabian)

Previous versions
------------------
v1: https://lore.proxmox.com/pve-devel/20260603082557.25359-1-j.klocker@proxmox.com/t/#u


Link: https://bugzilla.proxmox.com/show_bug.cgi?id=7598


pve-storage:

Jakob Klocker (2):
  qemu-img: drop unused image resize timeout parameter
  fix #7598: qemu-img: increase timeout for image resizing in worker
    context

 src/PVE/Storage/Common.pm    | 9 +++++----
 src/PVE/Storage/LVMPlugin.pm | 2 +-
 src/PVE/Storage/Plugin.pm    | 2 +-
 3 files changed, 7 insertions(+), 6 deletions(-)


Summary over all repositories:
  3 files changed, 7 insertions(+), 6 deletions(-)

-- 
Generated by murpp 0.12.0



             reply	other threads:[~2026-08-04  9:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04  9:04 Jakob Klocker [this message]
2026-08-04  9:04 ` [PATCH pve-storage v2 1/2] qemu-img: drop unused image resize timeout parameter Jakob Klocker
2026-08-05 15:20   ` Elias Huhsovitz
2026-08-04  9:04 ` [PATCH pve-storage v2 2/2] fix #7598: qemu-img: increase timeout for image resizing in worker context Jakob Klocker
2026-08-05 15:30   ` Elias Huhsovitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804090438.58491-1-j.klocker@proxmox.com \
    --to=j.klocker@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal