public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v2] ui: ceph: pool: set target ratio to 0 when the value is not set
Date: Wed, 29 Jul 2026 12:26:25 +0200	[thread overview]
Message-ID: <20260729102628.276253-1-m.sandoval@proxmox.com> (raw)

Leaving the field empty in the web UI results in the parameter being dropped
before the API call and the value remaining unchanged on the pool.

We address this by passing down target_size_ratio=0 to the API if the value is
not explicitly set, this results in the key being unset on the pool.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

Notes:
    One can get the target_size_ratio using
    
        $ ceph osd pool get <POOL_NAME> target_size_ratio
    
    after setting the value to 0 through the API or Web UI (explicitly as 0, or
    leaving the field as empty) it should output
    
        Error ENOENT: option 'target_size_ratio' is not set on pool '<POOL_NAME>'
    
    Note that:
    - This is handled automatically for the target_size property.
    - The same fix does not work for the Min. # of PGs field
    
    Differences from v1:
     - Rebased on top of master
     - Reworded commit message

 www/manager6/ceph/Pool.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index 80d57f113..a64230fbc 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -234,7 +234,11 @@ Ext.define('PVE.CephPoolInputPanel', {
     onGetValues: function (values) {
         Object.keys(values || {}).forEach(function (name) {
             if (values[name] === '') {
-                delete values[name];
+                if (name === 'target_size_ratio') {
+                    values[name] = 0;
+                } else {
+                    delete values[name];
+                }
             }
         });
 
-- 
2.47.3





             reply	other threads:[~2026-07-29 10:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 10:26 Maximiliano Sandoval [this message]
2026-07-29 15:27 ` applied: [PATCH manager v2] ui: ceph: pool: set target ratio to 0 when the value is not set Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260729102628.276253-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal