From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox-i18n v3 09/12] make: add check-linguas target
Date: Mon, 27 Jul 2026 11:59:52 +0200 [thread overview]
Message-ID: <20260727095957.223209-10-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20260727095957.223209-1-m.sandoval@proxmox.com>
Cross-references the list of languages in LINGUAS and the *.po files. Note that
the check-%.po check already checks that all LINGUAS have a respective PO file.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Notes:
This should be equivalent to the less-verbose:
test "$(ls *.po | sed 's/.po//')" = "$(cat LINGUAS)"
but easier to understand why it fails on failure.
Makefile | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 6b655eb6..94aa3eef 100644
--- a/Makefile
+++ b/Makefile
@@ -202,5 +202,13 @@ upload: upload-pve upload-pmg upload-pbs upload-pdm
check-%: %.po
msgfmt --check $*.po
+.PHONY: check-linguas
+check-linguas:
+ sort --check --unique LINGUAS
+ set -e; for lang in $(shell ls *.po | sed 's/\.po//'); do \
+ echo "checking if $$lang is in LINGUAS"; \
+ grep --quiet --line-regexp $$lang LINGUAS; \
+ done
+
.PHONY: check
-check: $(addprefix check-, $(LINGUAS))
+check: $(addprefix check-, $(LINGUAS)) check-linguas
--
2.47.3
next prev parent reply other threads:[~2026-07-27 10:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 9:59 [PATCH proxmox-i18n v3 00/12] Makefile simplifications and improvements Maximiliano Sandoval
2026-07-27 9:59 ` [PATCH proxmox-i18n v3 01/12] make: catalog-%.mo: explicitly set template file Maximiliano Sandoval
2026-07-27 9:59 ` [PATCH proxmox-i18n v3 02/12] make: simplify msgmerge commands Maximiliano Sandoval
2026-07-27 9:59 ` [PATCH proxmox-i18n v3 03/12] make: clean: remove *.mo files Maximiliano Sandoval
2026-07-27 9:59 ` [PATCH proxmox-i18n v3 04/12] make: use long options for msgmerge and msginit Maximiliano Sandoval
2026-07-27 9:59 ` [PATCH proxmox-i18n v3 05/12] make: do_update: add --update for msgmerge Maximiliano Sandoval
2026-07-27 9:59 ` [PATCH proxmox-i18n v3 06/12] make: do_update: add --previous flag to msgmerge Maximiliano Sandoval
2026-07-27 9:59 ` [PATCH proxmox-i18n v3 07/12] gitignore: remove proxmox-datacenter-manager.pot Maximiliano Sandoval
2026-07-27 9:59 ` [PATCH proxmox-i18n v3 08/12] make: move linguas to a file Maximiliano Sandoval
2026-07-29 7:15 ` Maximiliano Sandoval
2026-07-27 9:59 ` Maximiliano Sandoval [this message]
2026-07-27 9:59 ` [PATCH proxmox-i18n v3 10/12] make: init-%.po: add language to linguas Maximiliano Sandoval
2026-07-27 9:59 ` [PATCH proxmox-i18n v3 11/12] make: add targets to update specific PO files Maximiliano Sandoval
2026-07-27 9:59 ` [PATCH proxmox-i18n v3 12/12] make: rename check-% target to check-%.po Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727095957.223209-10-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox