From: David Riley <d.riley@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-access-control v6 1/8] permission: add acl tree node parent lookup without node creation
Date: Thu, 16 Jul 2026 12:42:40 +0200 [thread overview]
Message-ID: <20260716104247.29047-2-d.riley@proxmox.com> (raw)
In-Reply-To: <20260716104247.29047-1-d.riley@proxmox.com>
Add helper function to look up ACL nodes by path without creating
missing nodes along the path. This is necessary for safely locating
paths intended for deletion or migration without side effects.
This is in preparation for the following SDN resource ACL pruning and
VNet migration changes.
Signed-off-by: David Riley <d.riley@proxmox.com>
Reviewed-by: Stefan Hanreich <s.hanreich@proxmox.com>
Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
Notes:
Difference from v5:
* The comment for find_acl_tree_node_parent now uses the POD
format.
src/PVE/AccessControl.pm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm
index 0d632b3..a47495e 100644
--- a/src/PVE/AccessControl.pm
+++ b/src/PVE/AccessControl.pm
@@ -1000,6 +1000,37 @@ sub find_acl_tree_node {
return $node;
}
+=head3 find_acl_tree_node_parent($root, $path)
+
+Finds an ACL node by path C<$path> starting from the root node
+C<$root>, without autovivifying (creating) missing nodes.
+Returns a list containing the parent node, the final path
+segment, and the target node itself.
+
+=cut
+
+sub find_acl_tree_node_parent {
+ my ($root, $path) = @_;
+
+ my $current = $root;
+ my $parent = undef;
+ my $last_key = undef;
+
+ my @split_path = split('/', $path);
+
+ for my $segment (@split_path) {
+ if (defined($current->{children}) && defined($current->{children}->{$segment})) {
+ $parent = $current;
+ $last_key = $segment;
+ $current = $current->{children}->{$segment};
+ } else {
+ return (undef, undef, undef);
+ }
+ }
+
+ return ($parent, $last_key, $current);
+}
+
sub add_user_group {
my ($username, $usercfg, $group) = @_;
--
2.47.3
next prev parent reply other threads:[~2026-07-16 10:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 10:42 [PATCH access-control/network v6 0/8] fix #7520: sdn: prune orphaned ACLs and handle VNet migrations David Riley
2026-07-16 10:42 ` David Riley [this message]
2026-07-16 10:42 ` [PATCH pve-access-control v6 2/8] fix #7520: sdn: add pruning SDN resources ACLs David Riley
2026-07-16 10:42 ` [PATCH pve-access-control v6 3/8] test: add sdn acl pruning tests David Riley
2026-07-16 10:42 ` [PATCH pve-access-control v6 4/8] permission: add helper to check for active permissions David Riley
2026-07-16 10:42 ` [PATCH pve-access-control v6 5/8] fix #7520: sdn: add VNet ACL migration David Riley
2026-07-16 10:42 ` [PATCH pve-access-control v6 6/8] test: add sdn acl migration tests David Riley
2026-07-16 10:42 ` [PATCH pve-network v6 7/8] sdn: refactor compile_running_cfg to use running_config helper David Riley
2026-07-16 10:42 ` [PATCH pve-network v6 8/8] fix #7520: config: prune orphaned and relocate moved VNet ACLs David Riley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716104247.29047-2-d.riley@proxmox.com \
--to=d.riley@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox