From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC PATCH pve-manager 0/2] add reload/upload buttons to iso selector
Date: Mon, 13 Jul 2026 13:36:58 +0200 [thread overview]
Message-ID: <20260713114205.2382258-1-d.csapak@proxmox.com> (raw)
It often happens that one forgot to upload an iso before starting the vm
wizard. instead of having to navigate to the storage and upload there,
add an inline upload button to the create wizard.
Using this space, we can add a general 'reload' button which reloads the
storage list as well as the file list for the selected storage.
Sending this as RFC for multiple reasons:
* This shows a modal window over another (upload over wizard), which is
a pattern we don't usually use. IMO it's fine here since it's a rather
minor use case, but still.
* Placement of the buttons: I tried with inline buttons as well as
'triggers', but both have serious disadvantages:
- inline buttons: don't count to the field width and it's hard with
extjs' layout to achieve a consistent size for storage and file
selector
- triggers: we'd have to handroll the svg/png images (like pmx-clear),
and i'm not very good with svgs in general. I tried to extract the
font-awesome icons into standalone svgs, but could not get a result
that was good enough (for me). Maybe someone else has more luck with
that? Aside from the icons this has another problem: it makes the
file selector content very narrow when there are multiple triggers
and the user might not see what is actually selected.
Dominik Csapak (2):
ui: iso selector: add 'reload' button
ui: iso selector: add 'upload' button in the create VM wizard
www/manager6/form/FileSelector.js | 12 +++++
www/manager6/form/IsoSelector.js | 75 ++++++++++++++++++++++++++++
www/manager6/form/StorageSelector.js | 11 +++-
www/manager6/qemu/CDEdit.js | 1 +
www/manager6/qemu/OSPanel.js | 1 +
5 files changed, 98 insertions(+), 2 deletions(-)
--
2.47.3
next reply other threads:[~2026-07-13 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 11:36 Dominik Csapak [this message]
2026-07-13 11:36 ` [RFC PATCH pve-manager 1/2] ui: iso selector: add 'reload' button Dominik Csapak
2026-07-13 11:37 ` [RFC PATCH pve-manager 2/2] ui: iso selector: add 'upload' button in the create VM wizard Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713114205.2382258-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox