From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH guest-common 2/2] fix #1964: replication config: add a setting to skip freezing guest filesystems
Date: Mon, 6 Jul 2026 16:03:52 +0200 [thread overview]
Message-ID: <20260706140354.475972-3-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20260706140354.475972-1-m.sandoval@proxmox.com>
We log an entry when a freeze would have happened and we skip it based on
replication.cfg.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
src/PVE/Replication.pm | 7 +++++++
src/PVE/ReplicationConfig.pm | 8 ++++++++
2 files changed, 15 insertions(+)
diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm
index ba4c2c1..79f0be4 100644
--- a/src/PVE/Replication.pm
+++ b/src/PVE/Replication.pm
@@ -300,6 +300,13 @@ sub replicate {
my $conf = $guest_class->load_config($vmid);
my ($running, $freezefs) = $guest_class->__snapshot_check_freeze_needed($vmid, $conf, 0);
+ if ($jobcfg->{'skip-freeze-fs'}) {
+ $logfunc->(
+ "replication job configured with 'skip-freeze-fs' enabled, not freezing guest filesystems"
+ ) if $freezefs;
+ $freezefs = 0;
+ }
+
my $volumes = $guest_class->get_replicatable_volumes(
$storecfg,
$vmid,
diff --git a/src/PVE/ReplicationConfig.pm b/src/PVE/ReplicationConfig.pm
index cf9ee01..fcedbfe 100644
--- a/src/PVE/ReplicationConfig.pm
+++ b/src/PVE/ReplicationConfig.pm
@@ -96,6 +96,13 @@ my $defaultData = {
format => 'pve-node',
optional => 1,
},
+ 'skip-freeze-fs' => {
+ description =>
+ "Wether to skip freezing & thawing the guest's filesystems during replication",
+ type => 'boolean',
+ optional => 1,
+ default => 0,
+ },
},
};
@@ -335,6 +342,7 @@ sub options {
schedule => { optional => 1 },
remove_job => { optional => 1 },
source => { optional => 1 },
+ 'skip-freeze-fs' => { optional => 1 },
};
}
--
2.47.3
prev parent reply other threads:[~2026-07-06 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 14:03 [PATCH guest-common 0/2] fix #1964: replication config: add a setting to skip freezing guest filesystems Maximiliano Sandoval
2026-07-06 14:03 ` [PATCH guest-common 1/2] replication config: remove unused Data::Dumper Maximiliano Sandoval
2026-07-06 14:03 ` Maximiliano Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706140354.475972-3-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox